End position for 12th house is wrong.

[aintHuman]

End position for 12th house ecliptic is not correct.

Should it not equal to the start position of the 1st house ?

I am getting the:
a) End position Ecliptic of 12th house equal to the Start Position Horizon of the 1st house, and
b) End position Horizon of 12th house equal to the Start Position Ecliptic of the 1st house
(ie swapped)

Maybe something to do with the modulo arithmetic in the following function:

utilities/astrology.js

export const constructHouses = (cuspsArray, ascendantDegrees, zodiac, language = 'en') => cuspsArray.map((cuspDegree, index) => {
  const houseId = index + 1;
  return new House({
    ascendantDegrees, eclipticDegreesStart: cuspDegree, eclipticDegreesEnd: cuspsArray[modulo(index + 1, cuspsArray.length + 1)], id: houseId, zodiac, language,
  });
});

Namely when calculating eclipticDegreesEnd, I doubt that it should be cuspsArray.length + 1, rather just cuspsArray.length

Example 1st House

Example corresponding 12th house

[aintHuman]

Is this repo maintained anymore ? Has the maintainer gone completely AWOL ?

[gabe56f]

@aintHuman Phaen's fork has fixed this back in April February

[aintHuman]

@aintHuman Phaen's fork has fixed this back in April February

Thanks, Which is the official release ? I note that Phaen's has in turn been forked about 50 times ?

[gabe56f]

Sorry for the late response, Phaen's hasn't been forked not even once. Github is a bit weird with displaying forks, and it shows all the forks of this repository too. 43 forks are the total amount of forks this one has, Phaen's is the only one that fixed such issues.

[aintHuman]

Github is a bit weird with displaying forks, and it shows all the forks of this repository too. 43 forks are the total amount of forks this one has

I see, gotcha.

Anyway, I am wondering why such a critical error / bug has not been merged into the master repo. I have posted several bugs / issues and not got a single acknowledgement from the maintainer, which is extremely frustrating.