Skip to content

Commit 245c4b0

Browse files
authored
Merge pull request #6 from 88labs/claude/flamboyant-mendel
fix: pin GitHub Actions to SHA in asset-size workflow
2 parents 248b8ea + 36e887a commit 245c4b0

2 files changed

Lines changed: 14 additions & 38 deletions

File tree

.github/workflows/asset-size.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ jobs:
88
runs-on: ubuntu-latest
99

1010
steps:
11-
- uses: actions/checkout@v2
11+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
1212
with:
1313
fetch-depth: 0
14-
- uses: chrysanthos/simple-asset-size-reporter@1.0.2
14+
- uses: chrysanthos/simple-asset-size-reporter@3c86a594c400b40a4ebe6418da605a5d2755ef52 # 1.0.2
1515
with:
1616
repo-token: "${{ secrets.GITHUB_TOKEN }}"
1717
files: '["dist/*.js"]'

.github/workflows/tests.yml

Lines changed: 12 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
node-version: [10.x, 12.x, 14.x, 16.x, 17.x, 18.x, 19.x, 20.x]
17-
os: [ubuntu-latest, macOS-latest, windows-latest]
16+
node-version: [18.x, 20.x, 22.x, 24.x]
17+
os: [ubuntu-latest, windows-latest]
1818
runs-on: ${{ matrix.os }}
1919

2020
steps:
@@ -24,20 +24,12 @@ jobs:
2424
git config --global core.autocrlf false
2525
git config --global core.symlinks true
2626
if: runner.os == 'Windows'
27-
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #latest v4. TODO upgrade
27+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
2828
- name: Use Node.js ${{ matrix.node-version }}
29-
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d #latest v3. TODO upgrade
29+
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
3030
with:
3131
node-version: ${{ matrix.node-version }}
32-
- name: Create the npm cache directory
33-
run: mkdir npm-cache && npm config set cache ./npm-cache --global
34-
- name: Cache node modules
35-
uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84 #latest v3 TODO upgrade
36-
with:
37-
path: ./npm-cache
38-
key: v1-${{ runner.os }}-node-${{ matrix.node-version }}-npm-${{ hashFiles('**/package.json') }}
39-
restore-keys: |
40-
v1-${{ runner.os }}-node-${{ matrix.node-version }}-npm-
32+
cache: 'npm'
4133
- run: npm install
4234
- run: npm test
4335
env:
@@ -49,19 +41,11 @@ jobs:
4941
runs-on: ubuntu-latest
5042

5143
steps:
52-
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #latest v4. TODO upgrade
53-
- uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d #latest v3. TODO upgrade
44+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
45+
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
5446
with:
5547
node-version: 18
56-
- name: Create the npm cache directory
57-
run: mkdir npm-cache && npm config set cache ./npm-cache --global
58-
- name: Cache node modules
59-
uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84 #latest v3 TODO upgrade
60-
with:
61-
path: ./npm-cache
62-
key: v1-npm-${{ hashFiles('**/package.json') }}
63-
restore-keys: |
64-
v1-npm-
48+
cache: 'npm'
6549
- run: npm install
6650
- run: npm run benchmark
6751
env:
@@ -73,21 +57,13 @@ jobs:
7357
runs-on: ubuntu-latest
7458

7559
steps:
76-
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #latest v4. TODO upgrade
77-
- uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d #latest v3. TODO upgrade
60+
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
61+
- uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6
7862
with:
7963
node-version: 18
80-
- name: Create the npm cache directory
81-
run: mkdir npm-cache && npm config set cache ./npm-cache --global
82-
- name: Cache node modules
83-
uses: actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84 #latest v3 TODO upgrade
84-
with:
85-
path: ./npm-cache
86-
key: v1-npm-${{ hashFiles('**/package.json') }}
87-
restore-keys: |
88-
v1-npm-
64+
cache: 'npm'
8965
- run: npm install
9066
- run: npm install typescript
91-
- run: tsc index.d.ts
67+
- run: tsc index.d.ts --ignoreConfig --types node
9268
env:
9369
CI: true

0 commit comments

Comments
 (0)