Rate limiting allow list regression

[proxict]

Prerequisites

• I have checked the Wiki and Discussions and found no answer

• I have searched other issues and found no duplicates

• I want to report a bug and not ask a question or ask for help

• I have set up AdGuard Home correctly and configured clients to use it. (Use the Discussions for help with installing and configuring clients.)

Platform (OS and CPU architecture)

FreeBSD, AMD64 (aka x86_64)

Installation

Custom package (OpenWrt, HomeAssistant, etc; please mention in the description)

Setup

On a router, DHCP is handled by the router

AdGuard Home version

v0.107.74

Action

for c in {0..31}; do dig example.com +short && echo; done

Expected result

I expected to see 32 successfully resolved sets of IP addresses:

123.123.123.123
231.231.231.231

repeated 32 times.

Actual result

I only see 20 sets of IP addresses (my rate limit is set to 20):

123.123.123.123
231.231.231.231

repeated 20 times.

Additional information and/or screenshots

I have AdGuardHome installed on an OPNSense firewall and after the latest update, rate limiting allowlist seems to have stopped working.

With rate limit set to 20, AdGuardHome should only resolve 20 DNS requests per second, unless the client issuing the request is on the allow list. When the client is on the allow list, AdGuardHome shouldn't apply any rate limiting for that client.

Setting rate limit to 0 correctly disables rate limiting.

[VsevolodNaumov]

Confirmed, I can reproduce the issue. Forwarded to the dev team for investigation.