Skip to content

Commit f2d5eaa

Browse files
ashish921998claude
andcommitted
fix(ci): address reviewer feedback on permissions and ordering
- Remove id-token:write from both workflows (unused — no OIDC/provenance) - Move HUSKY=0 before pnpm install in both workflows so install hooks can't fire before the env var is set - Add comments on canary-temp.md lifecycle and CANARY_VERSION path - Update stale version placeholder in CONTRIBUTING.md to x.y.z-nightly-<sha> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 034c343 commit f2d5eaa

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

.github/workflows/canary.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ concurrency:
1313
permissions:
1414
contents: read
1515
pull-requests: write
16-
id-token: write
1716

1817
jobs:
1918
canary:
@@ -53,10 +52,10 @@ jobs:
5352
cache: pnpm
5453
registry-url: https://registry.npmjs.org
5554

56-
- run: pnpm install --frozen-lockfile
55+
- run: echo "HUSKY=0" >> $GITHUB_ENV
5756
if: steps.check_sha.outputs.skip == 'false'
5857

59-
- run: echo "HUSKY=0" >> $GITHUB_ENV
58+
- run: pnpm install --frozen-lockfile
6059
if: steps.check_sha.outputs.skip == 'false'
6160

6261
- run: pnpm -r --filter '!@aoagents/ao-web' build
@@ -65,7 +64,8 @@ jobs:
6564
- name: Create snapshot versions
6665
if: steps.check_sha.outputs.skip == 'false'
6766
run: |
68-
# If no changesets exist, create a minimal one so snapshot has something to work with.
67+
# If no changesets exist (e.g. after a Version Packages merge), create a minimal one.
68+
# changeset version --snapshot consumes and deletes it — no cleanup needed.
6969
if [ -z "$(ls .changeset/*.md 2>/dev/null | grep -vi 'README')" ]; then
7070
printf -- '---\n"@aoagents/ao": patch\n---\n\nchore: canary build\n' > .changeset/canary-temp.md
7171
fi
@@ -78,6 +78,7 @@ jobs:
7878
id: publish
7979
run: |
8080
pnpm changeset publish --tag nightly --no-git-tag
81+
# packages/ao is the user-facing CLI package; update this path if the package is renamed.
8182
CANARY_VERSION=$(node -p "require('./packages/ao/package.json').version")
8283
echo "version=$CANARY_VERSION" >> "$GITHUB_OUTPUT"
8384
env:

.github/workflows/release.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ concurrency:
1111
permissions:
1212
contents: write
1313
pull-requests: write
14-
id-token: write
1514

1615
jobs:
1716
release:
@@ -27,8 +26,8 @@ jobs:
2726
node-version: 20
2827
cache: pnpm
2928
registry-url: https://registry.npmjs.org
30-
- run: pnpm install --frozen-lockfile
3129
- run: echo "HUSKY=0" >> $GITHUB_ENV
30+
- run: pnpm install --frozen-lockfile
3231
- run: pnpm -r --filter '!@aoagents/ao-web' build
3332
- uses: changesets/action@v1
3433
with:

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ Without this secret, both `release.yml` and `canary.yml` will fail at the publis
8080
### After your PR merges (~15 min)
8181
The canary bot comments on your merged PR with the exact install command:
8282
```bash
83-
npm install -g @aoagents/ao@0.2.5-nightly-abc1234
83+
npm install -g @aoagents/ao@x.y.z-nightly-<sha>
8484
```
8585

8686
### Latest main at any time

0 commit comments

Comments
 (0)