Problems with file paths on Windows

[Mistale]

When building LazyJJ from source, file diffs are not working on Windows:

This seems to be related to the recent change of how file paths are supplied to the diff command 83f60ce

Quotes are escaped, but backslashes are not.

Using debug formatting for the path instead of applying manual escaping seems to work for both quotes and backslashes, i.e replacing all occurrences of let fileset = format!("file:\"{}\"", path.replace('"', "\\\"")) with let fileset = format!("file:{path:?}").

[peso]

That looks like a beautiful fix. It simplifies and improves functionality at the same time.

Is it possible for you to make a PR for it?

[Mistale]

Thank you! I’m on holiday at the moment, away from my dev machine. So I can’t contribute via PRs right now, but feel free to incorporate the change yourself in the meantime if you want to.

[dotdash]

Using Rust's debug output format there just works by accident for that case. Others are broken, e.g. a filename like v\x03v (for whatever reason you might have that) would be represented as "v\u{3}v" which is not a supported escape sequence in jj.

[dotdash]

FTR: a file called foo\foo on Linux breaks as well.

[dotdash]

FYI, this is fixed in blazingjj