Skip to content

Commit 688537d

Browse files
committed
Try removing two old hacks.
Running `just profile-test` seems to no longer fail now that we've done some hardening work (to support 0.11). So let's kill crazy hacks and see if we regret that later and need to add them back again.
1 parent 4cc8000 commit 688537d

2 files changed

Lines changed: 2 additions & 8 deletions

File tree

lua/lean/infoview.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ function Infoview:__update()
441441
return
442442
end
443443
info:set_last_window()
444-
pcall(info.move_pin, info, util.make_position_params())
444+
info:move_pin(util.make_position_params())
445445
end
446446

447447
---Directly mark that the infoview has died. What a shame.

lua/lean/lsp.lua

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -313,13 +313,7 @@ local function file_progress_handler(err, params)
313313
end
314314

315315
require('lean.progress').update(params)
316-
-- XXX: Similar to the equivalent line below, this second pcall seems to have
317-
-- become necessary when we started deleting clean buffers in tests.
318-
-- That's.. very suspicious, because it probably means it's necessary
319-
-- for "real life" use cases as well. So something isn't being handled
320-
-- correctly here. Without this though, tests in the sorry spec?? and
321-
-- not others seem to fail nondeterministically around 50% of the time.
322-
pcall(require('lean.infoview').__update_pin_by_uri, params.textDocument.uri)
316+
require('lean.infoview').__update_pin_by_uri(params.textDocument.uri)
323317

324318
require('lean.progress_bars').update(params)
325319
end

0 commit comments

Comments
 (0)