Skip to content

Commit 6120810

Browse files
authored
ci: remove case_validator.py from ALWAYS_RUN_ALL for smarter pruning (#1330)
1 parent febffab commit 6120810

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

toolchain/mfc/test/coverage.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@
4444
# are conservatively included (not in cache -> always runs).
4545
# - definitions.py: adding a parameter doesn't affect tests that don't use it;
4646
# the PR's .fpp changes trigger the relevant tests via coverage overlap.
47+
# - case_validator.py: validation only affects user-facing error messages for
48+
# invalid configs, not test outputs (tests use valid configs).
4749
ALWAYS_RUN_ALL = frozenset(
4850
[
4951
"CMakeLists.txt",
@@ -56,7 +58,6 @@
5658
"toolchain/mfc/test/case.py",
5759
"toolchain/mfc/test/coverage.py",
5860
"toolchain/mfc/run/input.py",
59-
"toolchain/mfc/case_validator.py",
6061
]
6162
)
6263

toolchain/mfc/test/test_coverage_unit.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,8 +237,9 @@ def test_definitions_py_does_not_trigger_all(self):
237237
def test_input_py_triggers_all(self):
238238
assert should_run_all_tests({"toolchain/mfc/run/input.py"}) is True
239239

240-
def test_case_validator_triggers_all(self):
241-
assert should_run_all_tests({"toolchain/mfc/case_validator.py"}) is True
240+
def test_case_validator_does_not_trigger_all(self):
241+
"""case_validator.py removed: validation only affects error messages, not test outputs."""
242+
assert should_run_all_tests({"toolchain/mfc/case_validator.py"}) is False
242243

243244
def test_cmakelists_triggers_all(self):
244245
assert should_run_all_tests({"CMakeLists.txt"}) is True

0 commit comments

Comments
 (0)