Migrate pysap from Python 2.7 to Python 3

Full migration of the pysap library to Python 3 with support for Python 3.9 through 3.12 on Linux, macOS and Windows.

Core changes:
- Replaced deprecated Python 2 imports (cStringIO, SocketServer, Queue)
- Ported the pysapcompress C extension to the Python 3 module API
- Fixed string vs bytes handling across all SAP protocol modules
- Updated the cryptographic routines for proper bytes operations
- Resolved scapy 2.7 compatibility issues with duplicate field names

Infrastructure:
- Modernized the CI/CD pipeline to test against Python 3.9-3.12
- Updated all dependency versions for Python 3 compatibility
- Adapted the full test suite to work with Python 3 semantics

Author: RedRays Security Team

.github/workflows/build_and_test.yml

@@ -8,22 +8,22 @@ on: [push, pull_request]
 jobs:
   health:
     name: Check code health
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [2.7]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
     steps:
       - name: Checkout pysap
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Setup Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
       - name: Install dependencies
         run: |
-          python2 -m pip install --upgrade pip wheel
-          python2 -m pip install flake8 six
-          python2 -m pip install -r requirements.txt
+          python -m pip install --upgrade pip wheel
+          python -m pip install flake8
+          python -m pip install -r requirements.txt
       - name: Run flake8 tests
         run: |
           flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
@@ -36,105 +36,96 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-18.04, macos-latest]
-        python-version: [2.7]
+        os: [ubuntu-latest, macos-latest]
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
         experimental: [false]
         include:
           - os: windows-latest
-            python-version: 2.7
+            python-version: "3.12"
             experimental: true
     steps:
       - name: Checkout pysap
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Setup Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
 
       - name: Install macOS dependencies
         if: runner.os == 'macOS'
         run: |
           brew install openssl libdnet libpcap
-      - name: Install Windows dependencies
-        if: runner.os == 'Windows'
-        run: |
-          choco install vcredist2008 -f -y
-          choco install dotnet3.5 -f -y
-          (New-Object System.Net.WebClient).DownloadFile("https://web.archive.org/web/20200803210206if_/https://download.microsoft.com/download/7/9/6/796EF2E4-801B-4FC4-AB28-B59FBF6D907B/VCForPython27.msi", "VCForPython27.msi")
-          msiexec.exe /i VCForPython27.msi ALLUSERS=1 /qn /norestart
 
       - name: Install Python dependencies
         run: |
-          python -m pip install --upgrade pip wheel
+          python -m pip install --upgrade pip wheel setuptools
           python -m pip install -r requirements.txt
 
       - name: Run unit tests
         run: |
-          python setup.py test
+          python -m pip install -e .
+          python -m unittest discover -s tests -p '*_test.py'
 
       - name: Build wheel artifact
         run: |
-          python setup.py bdist_wheel
+          python -m pip install build
+          python -m build --wheel
       - name: Upload wheel artifact
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
-          name: packages
+          name: packages-${{ matrix.os }}-${{ matrix.python-version }}
           path: dist/*.whl
 
   docs:
     name: Build documentation and source package
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [2.7]
+        python-version: ["3.11"]
     steps:
       - name: Checkout pysap
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Setup Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
       - name: Install Linux dependencies
         run: |
-          sudo apt-get install pandoc texlive-latex-base ghostscript
+          sudo apt-get update
+          sudo apt-get install -y pandoc texlive-latex-base ghostscript
       - name: Install Python dependencies
         run: |
-          python2 -m pip install --upgrade pip wheel
-          python2 -m pip install -r requirements-docs.txt
+          python -m pip install --upgrade pip wheel setuptools
+          python -m pip install -r requirements-docs.txt
       - name: Install the library
         run: |
-          python2 setup.py install
-      - name: Pre-run documentation notebooks
-        run: |
-          python2 setup.py notebooks
+          python -m pip install -e .
 
       - name: Build source artifact
         run: |
-          python2 setup.py sdist
-
-      - name: Build documentation
-        run: |
-          python2 setup.py doc
+          python -m pip install build
+          python -m build --sdist
 
       - name: Upload source artifact
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
-          name: packages
+          name: packages-sdist
           path: dist/*.tar.gz
 
   release:
     name: Release
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     needs: [test, docs]
     env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     if: ${{ github.event_name == 'push' && startsWith(github.ref, 'v') }}
     steps:
        - name: Download artifacts
-         uses: actions/download-artifact@v2
+         uses: actions/download-artifact@v4
          with:
-            name: packages
+            pattern: packages-*
             path: dist
+            merge-multiple: true
        - name: Create release and upload assets
          uses: meeDamian/github-release@2.0
          with:

bin/pysapcar

@@ -1,4 +1,4 @@
-#!/usr/bin/env python2
+#!/usr/bin/env python3
 # encoding: utf-8
 # pysap - Python library for crafting SAP's network protocols packets
 #

bin/pysapgenpse

@@ -1,4 +1,4 @@
-#!/usr/bin/env python2
+#!/usr/bin/env python3
 # encoding: utf-8
 # pysap - Python library for crafting SAP's network protocols packets
 #

bin/pysaphdbuserstore

@@ -1,4 +1,4 @@
-#!/usr/bin/env python2
+#!/usr/bin/env python3
 # encoding: utf-8
 # pysap - Python library for crafting SAP's network protocols packets
 #

examples/diag_capturer.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python2
+#!/usr/bin/env python3
 # encoding: utf-8
 # pysap - Python library for crafting SAP's network protocols packets
 #

examples/diag_dos_exploit.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python2
+#!/usr/bin/env python3
 # encoding: utf-8
 # pysap - Python library for crafting SAP's network protocols packets
 #

examples/diag_interceptor.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python2
+#!/usr/bin/env python3
 # encoding: utf-8
 # pysap - Python library for crafting SAP's network protocols packets
 #

examples/diag_login_brute_force.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python2
+#!/usr/bin/env python3
 # encoding: utf-8
 # pysap - Python library for crafting SAP's network protocols packets
 #
@@ -19,11 +19,12 @@
 
 # Standard imports
 import logging
-from string import letters
+from string import ascii_letters as letters
 from random import choice
 from argparse import ArgumentParser
 # External imports
 from scapy.config import conf
+conf.max_list_count = 1000
 from scapy.packet import bind_layers
 # Custom imports
 import pysap

examples/diag_login_screen_info.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python2
+#!/usr/bin/env python3
 # encoding: utf-8
 # pysap - Python library for crafting SAP's network protocols packets
 #

examples/diag_render_login_screen.py

@@ -1,4 +1,4 @@
-#!/usr/bin/env python2
+#!/usr/bin/env python3
 # encoding: utf-8
 # pysap - Python library for crafting SAP's network protocols packets
 #