diff verbs instead of recreating every time (#2545)

Co-authored-by: harryob <55142896+harryob@users.noreply.github.com>
Co-authored-by: wixoa <wixoag@gmail.com>

Author: hry-gh

OpenDreamClient/Interface/Controls/ControlInfo.cs

@@ -183,6 +183,7 @@ internal sealed class VerbPanel : InfoPanel {
     private readonly ClientVerbSystem? _verbSystem;
 
     private readonly VerbPanelGrid _grid;
+    private readonly Dictionary<(int VerbId, ClientObjectReference Src), Button> _verbButtons = new();
 
     private Color _highlightColor;
     private Color _textColor;
@@ -218,35 +219,52 @@ public override void UpdateElementDescriptor(ControlDescriptorInfo descriptor) {
     }
 
     public void RefreshVerbs(IEnumerable<(int, ClientObjectReference, VerbSystem.VerbInfo)> verbs) {
-        _grid.Children.Clear();
+        var panelVerbs = verbs
+            .Where(v => v.Item3.GetCategoryOrDefault(DefaultVerbPanel) == PanelName)
+            .Order(VerbNameComparer.OrdinalInstance);
+
+        var seenKeys = new HashSet<(int, ClientObjectReference)>();
+        var gridIndex = 0;
+        foreach (var (verbId, src, verbInfo) in panelVerbs) {
+            var key = (verbId, src);
+            seenKeys.Add(key);
+
+            if (!_verbButtons.ContainsKey(key)) {
+                var verbButton = new Button {
+                    Margin = new Thickness(2),
+                    Text = verbInfo.Name,
+                    TextAlign = Label.AlignMode.Center
+                };
+
+                verbButton.Label.Margin = new Thickness(6, 0, 6, 2);
+                verbButton.Label.FontColorOverride = _textColor;
+                verbButton.StyleBoxOverride = new StyleBoxEmpty();
 
-        foreach (var (verbId, src, verbInfo) in verbs.Order(VerbNameComparer.OrdinalInstance)) {
-            if (verbInfo.GetCategoryOrDefault(DefaultVerbPanel) != PanelName)
-                continue;
+                verbButton.OnButtonDown += _ => {
+                    _verbSystem?.ExecuteVerb(src, verbId);
+                };
 
-            Button verbButton = new Button {
-                Margin = new Thickness(2),
-                Text = verbInfo.Name,
-                TextAlign = Label.AlignMode.Center
-            };
+                verbButton.OnMouseEntered += _ => {
+                    verbButton.Label.FontColorOverride = _highlightColor;
+                };
 
-            verbButton.Label.Margin = new Thickness(6, 0, 6, 2);
-            verbButton.Label.FontColorOverride = _textColor;
-            verbButton.StyleBoxOverride = new StyleBoxEmpty();
+                verbButton.OnMouseExited += _ => {
+                    verbButton.Label.FontColorOverride = _textColor;
+                };
 
-            verbButton.OnButtonDown += _ => {
-                _verbSystem?.ExecuteVerb(src, verbId);
-            };
+                _verbButtons[key] = verbButton;
+                _grid.AddChild(verbButton);
+                verbButton.SetPositionInParent(gridIndex);
+            }
 
-            verbButton.OnMouseEntered += _ => {
-                verbButton.Label.FontColorOverride = _highlightColor;
-            };
+            gridIndex++;
+        }
 
-            verbButton.OnMouseExited += _ => {
-                verbButton.Label.FontColorOverride = _textColor;
-            };
+        foreach (var key in _verbButtons.Keys) {
+            if (seenKeys.Contains(key)) continue;
 
-            _grid.Children.Add(verbButton);
+            _grid.RemoveChild(_verbButtons[key]);
+            _verbButtons.Remove(key);
         }
     }
 }

TestGame/code.dm

@@ -206,6 +206,17 @@
 	verb/roll_dice(dice as text)
 		var/result = roll(dice)
 		usr << "The total shown on the dice is: [result]"
+		
+	verb/give_other_verb()
+		usr.verbs += /mob/proc/given_other_verb
+		usr << "other verb given"
+		
+	verb/take_other_verb()
+		usr.verbs -= /mob/proc/given_other_verb
+		usr << "other verb taken"
+	
+	proc/given_other_verb()
+		usr << "other verb working"
 
 	verb/test_alert()
 		set category = "Test"