Merge pull request #1403 from Privatech38/fix/revert-5-hover-tag-change

refactor(minimessage): revert change to Hover tag SNBT resolution

Author: kezz

text-minimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/standard/HoverTag.java

@@ -129,11 +129,13 @@ public HoverEvent.ShowItem parse(final ArgumentQueue args, final Context ctx) th
         final Key key = Key.key(args.popOr("Show item hover needs at least an item ID").value());
         final int count = args.hasNext() ? args.pop().asInt().orElseThrow(() -> ctx.newException("The count argument was not a valid integer")) : 1;
         if (args.hasNext()) {
-          // if the value starts with a '{' we assume it's SNBT. The previous behavior of legacy parsing has
-          // been removed in Adventure 5.0.0.
+          // Compatibility with legacy versions:
+          // if the value starts with a '{' we assume it's SNBT, and parse it as such to create a legacy holder
+          // otherwise, we'll parse argument pairs as a map of ResourceLocation -> SNBT value
           final String value = args.peek().value();
           if (value.startsWith("{")) {
-            throw ctx.newException("Legacy SNBT serializing is since Adventure 5.0.0 no longer supported.");
+            args.pop();
+            return legacyShowItem(key, count, value);
           }
 
           final Map<Key, DataComponentValue> datas = new HashMap<>();
@@ -152,6 +154,10 @@ public HoverEvent.ShowItem parse(final ArgumentQueue args, final Context ctx) th
       }
     }
 
+    private static HoverEvent.ShowItem legacyShowItem(final Key id, final int count, final String value) {
+      return HoverEvent.ShowItem.showItem(id, count, BinaryTagHolder.binaryTagHolder(value));
+    }
+
     @Override
     public void emit(final HoverEvent.ShowItem event, final TokenEmitter emit) {
       emit.argument(compactAsString(event.item()));