Merge pull request #1372 from Privatech38/feat/book-author

feat(api): Add pages-only constructor to BookImpl

Author: kezz

api/src/main/java/net/kyori/adventure/inventory/Book.java

@@ -23,7 +23,6 @@
  */
 package net.kyori.adventure.inventory;
 
-import java.util.ArrayList;
 import java.util.Collection;
 import java.util.List;
 import net.kyori.adventure.audience.Audience;
@@ -33,6 +32,8 @@
 import org.jetbrains.annotations.Contract;
 import org.jetbrains.annotations.Unmodifiable;
 
+import static java.util.Objects.requireNonNull;
+
 /**
  * Represents the in-game interface of a book.
  *
@@ -54,7 +55,7 @@ public sealed interface Book extends Buildable<Book.Builder>, BookLike permits B
    * @since 4.0.0
    */
   static Book book(final Component title, final Component author, final Collection<Component> pages) {
-    return new BookImpl(title, author, new ArrayList<>(pages));
+    return new BookImpl(requireNonNull(title, "title"), requireNonNull(author, "author"), List.copyOf(requireNonNull(pages, "pages")));
   }
 
   /**
@@ -67,7 +68,29 @@ static Book book(final Component title, final Component author, final Collection
    * @since 4.0.0
    */
   static Book book(final Component title, final Component author, final Component... pages) {
-    return book(title, author, List.of(pages));
+    return book(title, author, List.of(requireNonNull(pages)));
+  }
+
+  /**
+   * Creates a book with title and author set to {@link Component#empty()}.
+   *
+   * @param pages the collection of pages
+   * @return a book
+   * @since 5.1.0
+   */
+  static Book book(final Collection<Component> pages) {
+    return book(Component.empty(), Component.empty(), pages);
+  }
+
+  /**
+   * Creates a book with title and author set to {@link Component#empty()}.
+   *
+   * @param pages an array of pages
+   * @return a book
+   * @since 5.1.0
+   */
+  static Book book(final Component... pages) {
+    return book(Component.empty(), Component.empty(), pages);
   }
 
   /**

api/src/main/java/net/kyori/adventure/inventory/BookImpl.java

@@ -32,12 +32,6 @@
 import static java.util.Objects.requireNonNull;
 
 record BookImpl(Component title, Component author, List<Component> pages) implements Book {
-  BookImpl(final Component title, final Component author, final List<Component> pages) {
-    this.title = requireNonNull(title, "title");
-    this.author = requireNonNull(author, "author");
-    this.pages = List.copyOf(requireNonNull(pages, "pages"));
-  }
-
   @Override
   public Component title() {
     return this.title;
@@ -65,7 +59,7 @@ public List<Component> pages() {
 
   @Override
   public Book pages(final List<Component> pages) {
-    return new BookImpl(this.title, this.author, new ArrayList<>(requireNonNull(pages, "pages")));
+    return new BookImpl(this.title, this.author, List.copyOf(requireNonNull(pages, "pages")));
   }
 
   @Override
@@ -111,14 +105,15 @@ public Builder pages(final Collection<Component> pages) {
     }
 
     @Override
-    public Builder pages(final Component ... pages) {
+    public Builder pages(final Component... pages) {
+      requireNonNull(pages, "pages");
       Collections.addAll(this.pages, pages);
       return this;
     }
 
     @Override
     public Book build() {
-      return new BookImpl(this.title, this.author, List.copyOf(this.pages));
+      return new BookImpl(this.title, this.author, this.pages);
     }
   }
 }

api/src/test/java/net/kyori/adventure/inventory/BookTest.java

@@ -109,4 +109,13 @@ void testEquality() {
       )
       .testEquals();
   }
+
+  @Test
+  void testPagesOnly() {
+    final Book b = Book.book(arrayOfPages(1));
+    assertEquals(listOfPages(1), b.pages());
+    assertEquals(Component.empty(), b.title());
+    assertEquals(Component.empty(), b.author());
+  }
+
 }