Revert "fix: auto-save assets from store layer to survive tab switches"

This reverts commit 2decf2d.

Author: Leeon-Tang

src/components/playground/BatchOutputGrid.tsx

@@ -22,7 +22,6 @@ import {
   detectAssetType,
   generateDownloadFilename,
 } from "@/stores/assetsStore";
-import { storeSavedPredictionIds } from "@/stores/playgroundStore";
 import { toast } from "@/hooks/useToast";
 import { cn } from "@/lib/utils";
 import type { BatchResult, BatchQueueItem } from "@/types/batch";
@@ -195,11 +194,9 @@ export function BatchOutputGrid({
         if (autoSavedIndexesRef.current.has(result.index)) continue;
         if (result.error || result.outputs.length === 0) continue;
 
-        // Skip if store-level auto-save already handled this prediction
         if (
           result.prediction?.id &&
-          (storeSavedPredictionIds.has(result.prediction.id) ||
-            hasAssetForPrediction(result.prediction.id))
+          hasAssetForPrediction(result.prediction.id)
         ) {
           autoSavedIndexesRef.current.add(result.index);
           setSavedIndexes((prev) => new Set(prev).add(result.index));

src/components/playground/OutputDisplay.tsx

@@ -6,7 +6,6 @@ import {
   detectAssetType,
   generateDownloadFilename,
 } from "@/stores/assetsStore";
-import { storeSavedPredictionIds } from "@/stores/playgroundStore";
 import { Button } from "@/components/ui/button";
 import { Badge } from "@/components/ui/badge";
 import { Dialog, DialogContent, DialogTitle } from "@/components/ui/dialog";
@@ -135,7 +134,7 @@ export function OutputDisplay({
   const [gameEndedWithResults, setGameEndedWithResults] = useState(false);
   const prevOutputsLengthRef = useRef(0);
 
-  const { settings, loadSettings, saveAsset, hasAssetForPrediction } = useAssetsStore();
+  const { settings, loadSettings, saveAsset } = useAssetsStore();
 
   // Build list of media outputs for fullscreen navigation
   const mediaOutputs = useMemo(() => {
@@ -239,18 +238,6 @@ export function OutputDisplay({
     if (!settings.autoSaveAssets || !modelId || outputs.length === 0) return;
     if (!prediction?.id) return;
 
-    // Skip if store-level auto-save already handled this prediction
-    if (storeSavedPredictionIds.has(prediction.id) || hasAssetForPrediction(prediction.id)) {
-      // Mark all outputs as saved so the UI shows the correct state
-      for (let i = 0; i < outputs.length; i++) {
-        const output = outputs[i];
-        if (typeof output === "string" && detectAssetType(output)) {
-          setSavedIndexes((prev) => new Set(prev).add(i));
-        }
-      }
-      return;
-    }
-
     // Find outputs not yet auto-saved
     const unsaved: { output: string; index: number }[] = [];
     for (let i = 0; i < outputs.length; i++) {
@@ -316,7 +303,6 @@ export function OutputDisplay({
     modelId,
     settings.autoSaveAssets,
     saveAsset,
-    hasAssetForPrediction,
     t,
   ]);
 

src/stores/playgroundStore.ts

@@ -11,70 +11,6 @@ import type { BatchConfig, BatchState, BatchResult } from "@/types/batch";
 import { DEFAULT_BATCH_CONFIG } from "@/types/batch";
 import { persistentStorage } from "@/lib/storage";
 import { isImageUrl, isVideoUrl } from "@/lib/mediaUtils";
-import {
-  useAssetsStore,
-  detectAssetType,
-} from "@/stores/assetsStore";
-
-/* ── Store-level auto-save to My Assets ───────────────────────────────── */
-
-/**
- * Track prediction IDs that are currently being auto-saved (or already saved)
- * from the store layer. Shared between autoSaveToAssets and OutputDisplay
- * to prevent duplicate saves when both fire concurrently.
- */
-export const storeSavedPredictionIds = new Set<string>();
-
-/**
- * Auto-save prediction outputs to My Assets from the store layer.
- * This runs immediately when a prediction completes, regardless of which
- * tab is currently active — fixing the bug where switching tabs during
- * generation caused the OutputDisplay useEffect to miss the save.
- * Fire-and-forget; errors are logged but never thrown.
- */
-function autoSaveToAssets(
-  outputs: (string | Record<string, unknown>)[],
-  modelId: string,
-  predictionId: string | undefined,
-): void {
-  if (!predictionId) return;
-  if (storeSavedPredictionIds.has(predictionId)) return;
-
-  const { settings, saveAsset, hasAssetForPrediction } =
-    useAssetsStore.getState();
-  if (!settings.autoSaveAssets) return;
-  if (hasAssetForPrediction(predictionId)) return;
-
-  // Mark immediately to prevent concurrent duplicate from OutputDisplay
-  storeSavedPredictionIds.add(predictionId);
-
-  const unsaved: { output: string; index: number }[] = [];
-  for (let i = 0; i < outputs.length; i++) {
-    const output = outputs[i];
-    if (typeof output !== "string") continue;
-    if (output.startsWith("local-asset://")) continue;
-    const assetType = detectAssetType(output);
-    if (!assetType) continue;
-    unsaved.push({ output, index: i });
-  }
-  if (unsaved.length === 0) return;
-
-  // Fire-and-forget — save each output
-  (async () => {
-    for (const { output, index } of unsaved) {
-      try {
-        await saveAsset(output, detectAssetType(output)!, {
-          modelId,
-          predictionId,
-          originalUrl: output,
-          resultIndex: index,
-        });
-      } catch (err) {
-        console.error("[playgroundStore] auto-save asset failed:", err);
-      }
-    }
-  })();
-}
 
 /* ── Playground session persistence ───────────────────────────────────── */
 
@@ -643,9 +579,6 @@ export const usePlaygroundStore = create<PlaygroundState>((set, get) => ({
             : tab,
         ),
       }));
-
-      // Auto-save outputs to My Assets from store layer (tab-switch safe)
-      autoSaveToAssets(outputs, selectedModel.model_id, result.id);
     } catch (error) {
       // Don't show error for user-initiated abort
       const isAbort =
@@ -912,9 +845,6 @@ export const usePlaygroundStore = create<PlaygroundState>((set, get) => ({
               : tab,
           ),
         }));
-
-        // Auto-save outputs to My Assets from store layer (tab-switch safe)
-        autoSaveToAssets(batchOutputs, selectedModel.model_id, result.id);
       } catch (error) {
         // Skip state updates for aborted requests
         const isAbort =