Skip to content

Commit e6f0bbb

Browse files
committed
fix(stub): Compat with pyright 1.1.399+
1 parent 767a570 commit e6f0bbb

3 files changed

Lines changed: 23 additions & 17 deletions

File tree

src/lxml-stubs/html/_element.pyi

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ class HtmlElement(etree.ElementBase):
130130
__x: int,
131131
) -> HtmlElement: ...
132132
@overload
133-
def __getitem__(
133+
def __getitem__( # pyright: ignore[reportIncompatibleMethodOverride]
134134
self,
135135
__x: slice,
136136
) -> list[HtmlElement]: ...
@@ -141,14 +141,14 @@ class HtmlElement(etree.ElementBase):
141141
__v: HtmlElement,
142142
) -> None: ...
143143
@overload
144-
def __setitem__(
144+
def __setitem__( # pyright: ignore[reportIncompatibleMethodOverride]
145145
self,
146146
__x: slice,
147147
__v: Iterable[HtmlElement],
148148
) -> None: ...
149149
def __iter__(self) -> Iterator[HtmlElement]: ...
150150
def __reversed__(self) -> Iterator[HtmlElement]: ...
151-
def append(
151+
def append( # pyright: ignore[reportIncompatibleMethodOverride]
152152
self,
153153
element: HtmlElement,
154154
) -> None: ...
@@ -159,34 +159,34 @@ class HtmlElement(etree.ElementBase):
159159
elements: etree._Element,
160160
) -> Never: ...
161161
@overload
162-
def extend(
162+
def extend( # pyright: ignore[reportIncompatibleMethodOverride]
163163
self,
164164
elements: Iterable[HtmlElement],
165165
) -> None: ...
166-
def insert(
166+
def insert( # pyright: ignore[reportIncompatibleMethodOverride]
167167
self,
168168
index: int,
169169
element: HtmlElement,
170170
) -> None: ...
171-
def remove(
171+
def remove( # pyright: ignore[reportIncompatibleMethodOverride]
172172
self,
173173
element: HtmlElement,
174174
) -> None: ...
175-
def index(
175+
def index( # pyright: ignore[reportIncompatibleMethodOverride]
176176
self,
177177
child: HtmlElement,
178178
start: int | None = None,
179179
stop: int | None = None,
180180
) -> int: ...
181-
def addnext(
181+
def addnext( # pyright: ignore[reportIncompatibleMethodOverride]
182182
self,
183183
element: HtmlElement,
184184
) -> None: ...
185-
def addprevious(
185+
def addprevious( # pyright: ignore[reportIncompatibleMethodOverride]
186186
self,
187187
element: HtmlElement,
188188
) -> None: ...
189-
def replace(
189+
def replace( # pyright: ignore[reportIncompatibleMethodOverride]
190190
self,
191191
old_element: HtmlElement,
192192
new_element: HtmlElement,
@@ -264,13 +264,13 @@ class HtmlElement(etree.ElementBase):
264264
*,
265265
with_tail: bool = True,
266266
) -> Iterator[str]: ...
267-
makeelement: _ElementFactory[HtmlElement]
267+
makeelement: _ElementFactory[HtmlElement] # pyright: ignore[reportIncompatibleVariableOverride]
268268
def find(
269269
self,
270270
path: _ElemPathArg,
271271
namespaces: _StrOnlyNSMap | None = None,
272272
) -> HtmlElement | None: ...
273-
def findall(
273+
def findall( # pyright: ignore[reportIncompatibleMethodOverride]
274274
self,
275275
path: _ElemPathArg,
276276
namespaces: _StrOnlyNSMap | None = None,
@@ -280,7 +280,7 @@ class HtmlElement(etree.ElementBase):
280280
path: _ElemPathArg,
281281
namespaces: _StrOnlyNSMap | None = None,
282282
) -> Iterator[HtmlElement]: ...
283-
def cssselect(
283+
def cssselect( # pyright: ignore[reportIncompatibleMethodOverride]
284284
self,
285285
expr: str,
286286
*,

src/lxml-stubs/objectify/_element.pyi

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,9 @@ class ObjectifiedElement(ElementBase):
5050
def addattr(self, tag: _TagName, value: object) -> None: ...
5151
def countchildren(self) -> int: ...
5252
def descendantpaths(self, prefix: str | list[str] | None = None) -> list[str]: ...
53-
def getchildren(self) -> list[ObjectifiedElement]: ...
53+
def getchildren( # pyright: ignore[reportIncompatibleMethodOverride]
54+
self,
55+
) -> list[ObjectifiedElement]: ...
5456
def __iter__(self) -> Iterator[ObjectifiedElement]: ...
5557
def __reversed__(self) -> Iterator[ObjectifiedElement]: ...
5658
def __getattr__(self, __name: str) -> ObjectifiedElement: ...
@@ -62,7 +64,11 @@ class ObjectifiedElement(ElementBase):
6264
@overload
6365
def __getitem__(self, key: int | str | bytes, /) -> ObjectifiedElement: ...
6466
@overload
65-
def __getitem__(self, key: slice, /) -> list[ObjectifiedElement]: ...
67+
def __getitem__( # pyright: ignore[reportIncompatibleMethodOverride]
68+
self,
69+
key: slice,
70+
/,
71+
) -> list[ObjectifiedElement]: ...
6672
@overload
6773
def __setitem__(self, key: int | str | bytes, value: object, /) -> None: ...
6874
@overload
@@ -71,7 +77,7 @@ class ObjectifiedElement(ElementBase):
7177
# TODO Check if _Element methods need overriding
7278
# CSS selector is not a normal use case for objectified
7379
# element (and unnecessary), but still usable nonetheless
74-
def cssselect(
80+
def cssselect( # pyright: ignore[reportIncompatibleMethodOverride]
7581
self,
7682
expr: str,
7783
*,

tests/runtime/html_/test_link_funcs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ def test_wrong_type_raises(
256256
# yet they will never ever match class names
257257
def test_wrong_type_no_raise(self, disposable_html_element: HtmlElement) -> None:
258258
arg: Any
259-
for arg in ( # pyright: ignore[reportAssignmentType]
259+
for arg in ( # pyright: ignore[reportAssignmentType,reportUnknownVariableType]
260260
None,
261261
tuple(),
262262
True,

0 commit comments

Comments
 (0)