Skip to content

Commit 0a2b25e

Browse files
authored
Fix build error in H5vccMetricsImpl::RequestHistograms (youtube#8651)
Update H5vccMetricsImpl::RequestHistograms to use the APIs available in M114 for statistics recording and log finalization. This resolves build errors caused by using base::StatisticsRecorder ImportProvidedHistogramsSync and a different signature of FinalizeLog. Bug: 467384307
1 parent d03fd47 commit 0a2b25e

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

cobalt/browser/h5vcc_metrics/h5vcc_metrics_impl.cc

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void H5vccMetricsImpl::RequestHistograms(RequestHistogramsCallback callback) {
8585
// Synchronously fetch subprocess histograms that live in shared memory.
8686
// This is the only mechanism available to embedders like Cobalt, as the
8787
// fully async HistogramSynchronizer is a content internal implementation.
88-
base::StatisticsRecorder::ImportProvidedHistogramsSync();
88+
base::StatisticsRecorder::ImportProvidedHistograms();
8989

9090
auto* manager_client =
9191
cobalt::GlobalFeatures::GetInstance()->metrics_services_manager_client();
@@ -130,8 +130,7 @@ void H5vccMetricsImpl::RequestHistograms(RequestHistogramsCallback callback) {
130130
}
131131
}
132132
std::string encoded_log;
133-
log.FinalizeLog(false, service_client->GetVersionString(),
134-
log.GetCurrentClockTime(false), &encoded_log);
133+
log.FinalizeLog(false, service_client->GetVersionString(), &encoded_log);
135134
uma_proto.CopyFrom(*log.uma_proto());
136135

137136
cobalt::browser::metrics::CobaltUMAEvent cobalt_proto;

0 commit comments

Comments
 (0)