Skip to content

Commit 77d7333

Browse files
arun-superdomarun-superdom
committed
fix: resolve critical issues and improve APoP v1.0 spec compliance
Legal & Repo Hygiene: - Add Apache-2.0 LICENSE file - Add CONTRIBUTING.md with contribution guidelines - Add SECURITY.md with responsible disclosure policy - Remove todays-readme.md (working scratchpad, not spec content) - Fix Last Updated dates in spec docs from 2025 to 2026 - Fix lastModified in root agent-policy.json from 2025 to 2026 - Remove deprecated `version` key from docker-compose.yml Spec & Schema Fixes: - Simplify PolicyRule.allow to boolean-only (remove array form; use `actions` for listing allowed action types) - Update PathPolicy.allow to boolean-only in schema and TypeScript types - Add deprecation banner to SPEC.md (v0.1 draft) - Fix PROJECT_OVERVIEW.md status codes: 431→438, 432→439 - Fix discovery fallback order in implementation plan prompt - Fix ESM/CJS mismatch in schema-validate CI workflow - Mark policyUrl as RECOMMENDED in schema description - Add note about $schema/$id URL being a placeholder Glob Bug Fix: - Fix pathMatches() for /** patterns: require segment boundary match (prevents /deep/nestedXYZ matching /deep/nested/**) - Fix in middleware/index.express.js, middleware/index.js, and tests/conformance/helpers.js - Add regression test for segment boundary edge case Rate Limit Documentation: - Add Limitations section to sdk/node/README.md covering rate limiting (advisory-only) and signature verification (presence-check only) - Update REMAINING_WORK.md with explicit rate limiter and signature verification tasks - Clarify Agent-Policy-Rate-Remaining is max value, not actual remaining All tests pass: 111 conformance + 101 SDK tests.
1 parent 627fce9 commit 77d7333

22 files changed

Lines changed: 721 additions & 252 deletions

‎.github/workflows/schema-validate.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,9 @@ jobs:
4242

4343
- name: Validate schema is valid JSON Schema
4444
run: |
45-
node -e "
46-
const schema = require('./spec/schema/agent-policy.schema.json');
45+
node --input-type=module -e "
46+
import { readFileSync } from 'fs';
47+
const schema = JSON.parse(readFileSync('./spec/schema/agent-policy.schema.json', 'utf-8'));
4748
console.log('Schema title:', schema.title);
4849
console.log('Schema version:', schema.properties.version.default);
4950
console.log('Required fields:', schema.required);

‎CONTRIBUTING.md‎

Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
# Contributing to APoP (Agent Policy Protocol)
2+
3+
Thank you for your interest in contributing to the Agent Policy Protocol! APoP is an open standard, and community contributions are essential to its success.
4+
5+
## How to Contribute
6+
7+
### Reporting Issues
8+
9+
- Use [GitHub Issues](https://github.com/agent-policy-protocol/spec/issues) to report bugs, suggest features, or ask questions.
10+
- Search existing issues before creating a new one to avoid duplicates.
11+
- Include as much context as possible: version, environment, steps to reproduce.
12+
13+
### Proposing Changes to the Specification
14+
15+
1. **Open an issue first** — describe the problem or gap the change addresses.
16+
2. **Discuss** — wait for feedback from maintainers and the community before investing in a PR.
17+
3. **Submit a PR** — reference the issue number, explain the rationale, and include any relevant spec sections.
18+
19+
Spec changes require careful review since they affect all implementations. Please be patient during the review process.
20+
21+
### Contributing Code (SDK, Middleware, Tools)
22+
23+
1. **Fork** the repository and create a feature branch from `main`.
24+
2. **Follow existing patterns** — match the code style, naming conventions, and structure of the existing codebase.
25+
3. **Write tests** — all new functionality must include tests. Run the conformance test suite before submitting.
26+
4. **Keep PRs focused** — one logical change per PR. Large PRs are harder to review.
27+
28+
### Running Tests
29+
30+
```bash
31+
# Conformance tests
32+
cd tests/conformance
33+
npm install
34+
npm test
35+
36+
# SDK tests
37+
cd sdk/node
38+
npm install
39+
npm test
40+
```
41+
42+
### Code Style
43+
44+
- **JavaScript/TypeScript**: Follow the existing ESM conventions; use modern Node.js APIs (18+).
45+
- **JSON Schema**: Follow JSON Schema draft 2020-12 conventions.
46+
- **Markdown**: Use standard Markdown; keep line lengths reasonable.
47+
48+
## Pull Request Process
49+
50+
1. Ensure all tests pass and there are no linting errors.
51+
2. Update documentation if your change affects the public API or spec.
52+
3. Add a clear description of what changed and why.
53+
4. A maintainer will review your PR and may request changes.
54+
5. Once approved, a maintainer will merge your PR.
55+
56+
## Code of Conduct
57+
58+
This project follows the [Contributor Covenant Code of Conduct](https://www.contributor-covenant.org/version/2/1/code_of_conduct/). By participating, you agree to uphold this code. Please report unacceptable behavior to [security@agentpolicy.org](mailto:security@agentpolicy.org).
59+
60+
## License
61+
62+
By contributing to APoP, you agree that your contributions will be licensed under the [Apache License 2.0](LICENSE).

‎LICENSE‎

Lines changed: 190 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,190 @@
1+
Apache License
2+
Version 2.0, January 2004
3+
http://www.apache.org/licenses/
4+
5+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
6+
7+
1. Definitions.
8+
9+
"License" shall mean the terms and conditions for use, reproduction,
10+
and distribution as defined by Sections 1 through 9 of this document.
11+
12+
"Licensor" shall mean the copyright owner or entity authorized by
13+
the copyright owner that is granting the License.
14+
15+
"Legal Entity" shall mean the union of the acting entity and all
16+
other entities that control, are controlled by, or are under common
17+
control with that entity. For the purposes of this definition,
18+
"control" means (i) the power, direct or indirect, to cause the
19+
direction or management of such entity, whether by contract or
20+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
21+
outstanding shares, or (iii) beneficial ownership of such entity.
22+
23+
"You" (or "Your") shall mean an individual or Legal Entity
24+
exercising permissions granted by this License.
25+
26+
"Source" form shall mean the preferred form for making modifications,
27+
including but not limited to software source code, documentation
28+
source, and configuration files.
29+
30+
"Object" form shall mean any form resulting from mechanical
31+
transformation or translation of a Source form, including but
32+
not limited to compiled object code, generated documentation,
33+
and conversions to other media types.
34+
35+
"Work" shall mean the work of authorship, whether in Source or
36+
Object form, made available under the License, as indicated by a
37+
copyright notice that is included in or attached to the work
38+
(an example is provided in the Appendix below).
39+
40+
"Derivative Works" shall mean any work, whether in Source or Object
41+
form, that is based on (or derived from) the Work and for which the
42+
editorial revisions, annotations, elaborations, or other modifications
43+
represent, as a whole, an original work of authorship. For the purposes
44+
of this License, Derivative Works shall not include works that remain
45+
separable from, or merely link (or bind by name) to the interfaces of,
46+
the Work and Derivative Works thereof.
47+
48+
"Contribution" shall mean any work of authorship, including
49+
the original version of the Work and any modifications or additions
50+
to that Work or Derivative Works thereof, that is intentionally
51+
submitted to the Licensor for inclusion in the Work by the copyright owner
52+
or by an individual or Legal Entity authorized to submit on behalf of
53+
the copyright owner. For the purposes of this definition, "submitted"
54+
means any form of electronic, verbal, or written communication sent
55+
to the Licensor or its representatives, including but not limited to
56+
communication on electronic mailing lists, source code control systems,
57+
and issue tracking systems that are managed by, or on behalf of, the
58+
Licensor for the purpose of discussing and improving the Work, but
59+
excluding communication that is conspicuously marked or otherwise
60+
designated in writing by the copyright owner as "Not a Contribution."
61+
62+
"Contributor" shall mean Licensor and any individual or Legal Entity
63+
on behalf of whom a Contribution has been received by the Licensor and
64+
subsequently incorporated within the Work.
65+
66+
2. Grant of Copyright License. Subject to the terms and conditions of
67+
this License, each Contributor hereby grants to You a perpetual,
68+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
69+
copyright license to reproduce, prepare Derivative Works of,
70+
publicly display, publicly perform, sublicense, and distribute the
71+
Work and such Derivative Works in Source or Object form.
72+
73+
3. Grant of Patent License. Subject to the terms and conditions of
74+
this License, each Contributor hereby grants to You a perpetual,
75+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
76+
(except as stated in this section) patent license to make, have made,
77+
use, offer to sell, sell, import, and otherwise transfer the Work,
78+
where such license applies only to those patent claims licensable
79+
by such Contributor that are necessarily infringed by their
80+
Contribution(s) alone or by combination of their Contribution(s)
81+
with the Work to which such Contribution(s) was submitted. If You
82+
institute patent litigation against any entity (including a
83+
cross-claim or counterclaim in a lawsuit) alleging that the Work
84+
or a Contribution incorporated within the Work constitutes direct
85+
or contributory patent infringement, then any patent licenses
86+
granted to You under this License for that Work shall terminate
87+
as of the date such litigation is filed.
88+
89+
4. Redistribution. You may reproduce and distribute copies of the
90+
Work or Derivative Works thereof in any medium, with or without
91+
modifications, and in Source or Object form, provided that You
92+
meet the following conditions:
93+
94+
(a) You must give any other recipients of the Work or
95+
Derivative Works a copy of this License; and
96+
97+
(b) You must cause any modified files to carry prominent notices
98+
stating that You changed the files; and
99+
100+
(c) You must retain, in the Source form of any Derivative Works
101+
that You distribute, all copyright, patent, trademark, and
102+
attribution notices from the Source form of the Work,
103+
excluding those notices that do not pertain to any part of
104+
the Derivative Works; and
105+
106+
(d) If the Work includes a "NOTICE" text file as part of its
107+
distribution, then any Derivative Works that You distribute must
108+
include a readable copy of the attribution notices contained
109+
within such NOTICE file, excluding any notices that do not
110+
pertain to any part of the Derivative Works, in at least one
111+
of the following places: within a NOTICE text file distributed
112+
as part of the Derivative Works; within the Source form or
113+
documentation, if provided along with the Derivative Works; or,
114+
within a display generated by the Derivative Works, if and
115+
wherever such third-party notices normally appear. The contents
116+
of the NOTICE file are for informational purposes only and
117+
do not modify the License. You may add Your own attribution
118+
notices within Derivative Works that You distribute, alongside
119+
or as an addendum to the NOTICE text from the Work, provided
120+
that such additional attribution notices cannot be construed
121+
as modifying the License.
122+
123+
You may add Your own copyright statement to Your modifications and
124+
may provide additional or different license terms and conditions
125+
for use, reproduction, or distribution of Your modifications, or
126+
for any such Derivative Works as a whole, provided Your use,
127+
reproduction, and distribution of the Work otherwise complies with
128+
the conditions stated in this License.
129+
130+
5. Submission of Contributions. Unless You explicitly state otherwise,
131+
any Contribution intentionally submitted for inclusion in the Work
132+
by You to the Licensor shall be under the terms and conditions of
133+
this License, without any additional terms or conditions.
134+
Notwithstanding the above, nothing herein shall supersede or modify
135+
the terms of any separate license agreement you may have executed
136+
with Licensor regarding such Contributions.
137+
138+
6. Trademarks. This License does not grant permission to use the trade
139+
names, trademarks, service marks, or product names of the Licensor,
140+
except as required for reasonable and customary use in describing the
141+
origin of the Work and reproducing the content of the NOTICE file.
142+
143+
7. Disclaimer of Warranty. Unless required by applicable law or
144+
agreed to in writing, Licensor provides the Work (and each
145+
Contributor provides its Contributions) on an "AS IS" BASIS,
146+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
147+
implied, including, without limitation, any warranties or conditions
148+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
149+
PARTICULAR PURPOSE. You are solely responsible for determining the
150+
appropriateness of using or redistributing the Work and assume any
151+
risks associated with Your exercise of permissions under this License.
152+
153+
8. Limitation of Liability. In no event and under no legal theory,
154+
whether in tort (including negligence), contract, or otherwise,
155+
unless required by applicable law (such as deliberate and grossly
156+
negligent acts) or agreed to in writing, shall any Contributor be
157+
liable to You for damages, including any direct, indirect, special,
158+
incidental, or consequential damages of any character arising as a
159+
result of this License or out of the use or inability to use the
160+
Work (including but not limited to damages for loss of goodwill,
161+
work stoppage, computer failure or malfunction, or any and all
162+
other commercial damages or losses), even if such Contributor
163+
has been advised of the possibility of such damages.
164+
165+
9. Accepting Warranty or Additional Liability. While redistributing
166+
the Work or Derivative Works thereof, You may choose to offer,
167+
and charge a fee for, acceptance of support, warranty, indemnity,
168+
or other liability obligations and/or rights consistent with this
169+
License. However, in accepting such obligations, You may act only
170+
on Your own behalf and on Your sole responsibility, not on behalf
171+
of any other Contributor, and only if You agree to indemnify,
172+
defend, and hold each Contributor harmless for any liability
173+
incurred by, or claims asserted against, such Contributor by reason
174+
of your accepting any such warranty or additional liability.
175+
176+
END OF TERMS AND CONDITIONS
177+
178+
Copyright 2026 Superdom AI Research Labs Pvt Ltd
179+
180+
Licensed under the Apache License, Version 2.0 (the "License");
181+
you may not use this file except in compliance with the License.
182+
You may obtain a copy of the License at
183+
184+
http://www.apache.org/licenses/LICENSE-2.0
185+
186+
Unless required by applicable law or agreed to in writing, software
187+
distributed under the License is distributed on an "AS IS" BASIS,
188+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
189+
See the License for the specific language governing permissions and
190+
limitations under the License.

‎SECURITY.md‎

Lines changed: 50 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
# Security Policy
2+
3+
## Reporting a Vulnerability
4+
5+
If you discover a security vulnerability in the Agent Policy Protocol specification, reference implementations, or SDK, please report it responsibly.
6+
7+
**Do NOT open a public GitHub issue for security vulnerabilities.**
8+
9+
### How to Report
10+
11+
Send an email to **[security@agentpolicy.org](mailto:security@agentpolicy.org)** with:
12+
13+
- A description of the vulnerability
14+
- Steps to reproduce the issue
15+
- The potential impact
16+
- Any suggested fixes (optional)
17+
18+
### What to Expect
19+
20+
- **Acknowledgment**: We will acknowledge receipt within 48 hours.
21+
- **Assessment**: We will assess the severity and impact within 5 business days.
22+
- **Fix**: We will work on a fix and coordinate disclosure with you.
23+
- **Disclosure**: We will publicly disclose the vulnerability after a fix is available, crediting you (unless you prefer anonymity).
24+
25+
## Scope
26+
27+
This security policy covers:
28+
29+
- The APoP specification (`spec/`)
30+
- The JSON Schema (`spec/schema/agent-policy.schema.json`)
31+
- The Node.js SDK (`sdk/node/`)
32+
- The reference middleware (`middleware/`)
33+
- The conformance test suite (`tests/`)
34+
35+
## Supported Versions
36+
37+
| Version | Supported |
38+
| ------- | ------------------ |
39+
| 1.0.x | :white_check_mark: |
40+
| < 1.0 | :x: |
41+
42+
## Security Best Practices for Implementors
43+
44+
When implementing APoP in production:
45+
46+
1. **Always validate** `agent-policy.json` against the JSON Schema before loading.
47+
2. **Use HTTPS** for all policy URLs, verification endpoints, and registry lookups.
48+
3. **Implement rate limiting** with a proper backend (in-memory counters, Redis, etc.) — the SDK's rate limit headers are advisory only.
49+
4. **Verify agent signatures** cryptographically — the SDK currently checks for header presence only, not cryptographic validity.
50+
5. **Sanitize inputs** — agent headers (`Agent-Name`, `Agent-Intent`, etc.) are untrusted input.

0 commit comments

Comments
 (0)