ether: Show link state in ether_print, add shared ethphy_print_status()

Add Link: UP/DOWN at top of ether_print() using NETIF_F_UP flag.
Add ethphy_print_status() for standard BMSR/ANLPAR link/speed/duplex
printing, used by both dp83826 and generic PHY drivers.
Add print_info to generic PHY driver showing PHY ID and link status.

Author: andoma

include/mios/ethphy.h

@@ -32,3 +32,5 @@ error_t ethphy_mii_write(struct ether_netif *eni, uint16_t reg, uint16_t value);
  * Raises NETIF_TASK_STATUS_UP/DOWN on transitions.
  */
 void ethphy_link_poll(struct ether_netif *eni) __attribute__((noreturn));
+
+void ethphy_print_status(struct ether_netif *eni, struct stream *s);

src/net/ether.c

@@ -341,6 +341,9 @@ ether_netif_fini(ether_netif_t *eni)
 void
 ether_print(ether_netif_t *en, struct stream *st)
 {
+  stprintf(st, "Link: %s\n",
+           (en->eni_ni.ni_flags & NETIF_F_UP) ? "UP" : "DOWN");
+
   stprintf(st, "Mac address: %02x:%02x:%02x:%02x:%02x:%02x\n",
            en->eni_addr[0],
            en->eni_addr[1],

src/net/ethphy/ethphy_dp83826.c

@@ -24,22 +24,13 @@ dp83826_print_info(struct device *dev, struct stream *s)
 
   uint16_t id2 = ethphy_mii_read(eni, REG_PHYIDR2);
   uint16_t model = (id2 >> 4) & 0x3f;
-  uint16_t bmsr = ethphy_mii_read(eni, REG_BMSR);
-  bmsr = ethphy_mii_read(eni, REG_BMSR); // Read twice -- link status is latched-low
-  uint16_t physts = ethphy_mii_read(eni, REG_PHYSTS);
-
-  stprintf(s, "DP83826%c rev %d\n",
-           model == 0x13 ? 'E' : 'I',
-           id2 & 0xf);
-
-  stprintf(s, "Link: %s, %s %s duplex\n",
-           (bmsr & (1 << 2)) ? "UP" : "DOWN",
-           (physts & (1 << 1)) ? "10M" : "100M",
-           (physts & (1 << 2)) ? "full" : "half");
 
   uint16_t rcsr = ethphy_mii_read(eni, REG_RCSR);
-  stprintf(s, "Interface: %sMII\n",
+  stprintf(s, "DP83826%c rev %d  Interface: %sMII\n",
+           model == 0x13 ? 'E' : 'I',
+           id2 & 0xf,
            (rcsr & 0x20) ? "R" : "");
+  ethphy_print_status(eni, s);
 }
 
 static const device_class_t ethphy_dp83826 = {

src/net/ethphy/ethphy_generic.c

@@ -1,11 +1,50 @@
 #include <mios/ethphy.h>
 #include <mios/driver.h>
 #include <mios/eventlog.h>
+#include <stdio.h>
 
 #include <net/ether.h>
 
+void
+ethphy_print_status(struct ether_netif *eni, struct stream *s)
+{
+  uint16_t bmsr = ethphy_mii_read(eni, 0x01);
+  bmsr = ethphy_mii_read(eni, 0x01); // Read twice -- link status is latched-low
+
+  if(bmsr & (1 << 2)) {
+    uint16_t adv = ethphy_mii_read(eni, 0x04);
+    uint16_t lpa = ethphy_mii_read(eni, 0x05);
+    int common = adv & lpa;
+    const char *speed = "10M";
+    const char *duplex = "half";
+    if(common & (1 << 8)) {
+      speed = "100M"; duplex = "full";
+    } else if(common & (1 << 7)) {
+      speed = "100M";
+    } else if(common & (1 << 6)) {
+      duplex = "full";
+    }
+    stprintf(s, "Link: UP, %s %s duplex\n", speed, duplex);
+  } else {
+    stprintf(s, "Link: DOWN\n");
+  }
+}
+
+static void
+generic_print_info(struct device *dev, struct stream *s)
+{
+  struct ether_netif *eni = (struct ether_netif *)dev->d_parent;
+  uint16_t id1 = ethphy_mii_read(eni, 0x02);
+  uint16_t id2 = ethphy_mii_read(eni, 0x03);
+
+  stprintf(s, "PHY OUI:0x%05x Model:0x%02x Rev:%d\n",
+           (id1 << 6) | (id2 >> 10), (id2 >> 4) & 0x3f, id2 & 0xf);
+  ethphy_print_status(eni, s);
+}
+
 static const device_class_t ethphy_generic = {
   .dc_class_name = "Generic PHY",
+  .dc_print_info = generic_print_info,
 };
 
 static device_t *