Skip to content

Commit 0a40300

Browse files
committed
Simplify genres tests
1 parent 0eed837 commit 0a40300

1 file changed

Lines changed: 12 additions & 15 deletions

File tree

test/plugins/test_musicbrainz.py

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -539,20 +539,6 @@ def test_parse_recording_artist_credits(self):
539539
"Recording Composer, The, Another Recording Composer, The"
540540
)
541541

542-
def test_genres(self):
543-
config["musicbrainz"]["genres"] = True
544-
config["musicbrainz"]["genres_tag"] = "genre"
545-
release = release_factory()
546-
d = self.mb.album_info(release)
547-
assert d.genres == ["Genre"]
548-
549-
def test_tags(self):
550-
config["musicbrainz"]["genres"] = True
551-
config["musicbrainz"]["genres_tag"] = "tag"
552-
release = release_factory()
553-
d = self.mb.album_info(release)
554-
assert d.genres == ["Tag"]
555-
556542
def test_track_disambiguation(self):
557543
release = release_factory(
558544
media__0__tracks=[
@@ -606,7 +592,7 @@ def mb(self, plugin_config):
606592
return musicbrainz.MusicBrainzPlugin()
607593

608594

609-
class TestDataTracks(MusicBrainzPluginTestMixin):
595+
class TestParse(MusicBrainzPluginTestMixin):
610596
@pytest.mark.parametrize(
611597
"beets_match_config, expected_titles",
612598
[
@@ -647,6 +633,17 @@ def test_data_tracks(self, config, beets_match_config, mb, expected_titles):
647633

648634
assert actual_titles == expected_titles
649635

636+
@pytest.mark.parametrize(
637+
"plugin_config, expected_genres",
638+
[
639+
_p({"genres": False}, None, id="genres disabled"),
640+
_p({"genres": True, "genres_tag": "genre"}, ["Genre"], id="use genres"),
641+
_p({"genres": True, "genres_tag": "tag"}, ["Tag"], id="use tags"),
642+
],
643+
) # fmt: skip
644+
def test_genres(self, mb, expected_genres):
645+
assert mb.album_info(release_factory()).genres == expected_genres
646+
650647

651648
class TestArtist:
652649
def test_single_artist(self):

0 commit comments

Comments
 (0)