Looking for review help on community-maintained features

[johnhurt]

Hey, Pingorians (Present and Future)! As many of the contributors here are (unfortunately) aware, the pingora maintainers are slow to review and accept PRs. There's only a handful of us, so we do our best to prioritize and accept the PRs and issues as they come in. One big place we have been falling behind is in the PRs for features we don't/can't use internally. Things like rustls integration and s2n tls integration were both graciously contributed by community members. We want to make sure those features are as well supported, tested, and trusted as the rest of pingora, but to do that, we are realizing we are going to need to empower people outside of our team to review and approve changes that affect those integrations. So we are looking for some volunteers that have knowledge and stake in these integrations and being the key approvers for prs dealing with

1. rustls
2. s2n

If you are interested in being an external envoy for one of these integration, please let us know here. Ideally we would like to have 3 for each. Thanks!

[hl11jp]

Can a person without Rust experience, but willing to learn, apply for this opportunity?

[johnhurt]

For this I'm afraid not 😓 but for literally anything else, yes! This (semi-)formal role should ideally be someone whom the community can trust to understand and review code changes that affect codepaths using these two tls integrations. There might be more integrations in the future that are less sensitive, but for now rust expertise is a important.

[hl11jp]

Hi John,

Thank you for your reply. I will continue studying and come back in six months. If the role has not been filled, I would love to apply again.

[johnhurt]

Looking at the people who have contributed the most to that codebase already, I was wondering if any of you would be willing to take on this responsibility. To be clear, all we want are a few people with vested interest in the rustls and s2n integration, that are willing to look at other contributors' work and mark it (with a comment) as accepted. The hope is that we have enough to get 2 approvals on any external pr without anyone having to review their own code 😅

rustls

@jsulmont
@fabian4
@tedscode
@nojima

s2n

@gilbertw1
@varunravi98
@jsulmont
@nojima

There are a couple duplicates there, so if you are willing to do both that's even better, but no pressure. Don't quote me on this (because I'm not in charge of the swag budget and shipping things internationally is tricky), but in exchange for this we might be able to send you some Pingora swag.

[nojima]

Hi @johnhurt, I'd be happy to help review rustls contributions. Looking forward to working with the team on this!
(s2n is outside my expertise so I won't be able to help there.)

[varunravi98]

Hey @johnhurt!
I’d be happy to help review s2n contributions (and continue making some of
my own, potentially) as I expect to be working with pingora and s2n in the
near future.

Varun

[fabian4]

Hi @johnhurt, count me in. Looking forward to working together with the community.

[johnhurt]

You all are amazing! Thank you! We will send some prs your way during our triage meeting on Friday. We appreciate anything you are willing to do, and look forward to working with you If you are okay with it, I will mention you (and this discussion) in our contribution page, so people know whom to butter for reviews.

Thanks again! 🤩

[gilbertw1]

Hey @johnhurt! I'd be happy to help review any s2n contributions, feel free to tag me on any of them.

Thanks!