5.1.8-4 backport deletion improvement

Author: cloudgge

CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [v5.1.8-4] - 2025-11-27
+### Fixed
+- [#166] improve stability of background user deletion script for temp admins
+  - backport to redmine 5
+
 ## [v5.1.8-3] - 2025-08-06
 ### Security
 - [#155] close CVE GHSA-353f-x4gh-cqq8

Dockerfile

@@ -1,7 +1,7 @@
 FROM registry.cloudogu.com/official/base:3.19.4-3
 
 LABEL NAME="official/redmine" \
-   VERSION="5.1.8-3" \
+   VERSION="5.1.8-4" \
    maintainer="hello@cloudogu.com"
 
 ENV USER=redmine \

docs/gui/release_notes_de.md

@@ -6,6 +6,14 @@ Technische Details zu einem Release finden Sie im zugehörigen [Changelog](https
 
 ## [Unreleased]
 
+## [v5.1.8-4] - 2025-11-27
+### Fixed
+* Robustheit des Löschvorgangs von temporären Admins erhöht.
+    * In Fehlerfällen können temporäre Admin Accounts in einem vorherigen Startversuch schon gelöscht wurden sein.
+        * Während der damit verbundene Schlüssel in der Konfiguration darauf hingewiesen hat das ein solcher Account noch existiert.
+        * Nachfolgende Löschversuche würden demnach fehlschlagen und die Konfiguration nicht richtig aufgeräumt werden, welches den Start des Dogu's verhindert.
+        * Dieses Release behebt diesen Fehler.
+      
 ## [v5.1.8-3] - 2025-08-06
 ### Changed
 * Wir haben nur technische Änderungen vorgenommen. Näheres finden Sie in den Changelogs.

docs/gui/release_notes_en.md

@@ -6,6 +6,14 @@ Technical details on a release can be found in the corresponding [Changelog](htt
 
 ## [Unreleased]
 
+## [v5.1.8-4] - 2025-11-27
+### Fixed
+* Robustness of deletion process for temporary admins improved.
+    * In Error Cases the temporary admin accounts were not properly deleted during a previous start attempt.
+        * While the connected Configuration Key indicated that the admin account was not deleted yet.
+        * Additional attempts at deleting this temporary account would fail and prevent proper Dogu Startup.
+        * This Error was fixed with this Release.
+
 ## [v5.1.8-3] - 2025-08-06
 ### Changed
 * We have only made technical changes. You can find more details in the changelogs.

dogu.json

@@ -1,6 +1,6 @@
 {
   "Name": "official/redmine",
-  "Version": "5.1.8-3",
+  "Version": "5.1.8-4",
   "DisplayName": "Redmine",
   "Description": "Redmine is a flexible project management web application",
   "Category": "Development Apps",

resources/rails_scripts/remove_user.rb

@@ -24,13 +24,13 @@ def symbolize_keys!
 begin
 opts = RemoveUserHelper::options
 puts "Try to remove user %s" % opts[:username]
-user = User.where(login: opts[:username]).first
-puts 'User did not exist' if user.nil?
-    user.destroy unless user.nil?
-    puts 'User removed successfully.' unless user.nil?
-    rescue Exception => error
-puts '====================================================='
-puts error.message
-puts '====================================================='
-puts 'User remove failed.'
+user = User.find_by_login(opts[:username])
+if user
+  user.destroy!
+else
+  puts "User did not exist"
+end
+rescue StandardError => e
+  warn "User deletion failed: #{e.class}: #{e.message}"
+  raise
 end