Skip to content

Commit 4f43dc6

Browse files
committed
5.1.8-4 backport deletion improvement
1 parent 81c96d8 commit 4f43dc6

6 files changed

Lines changed: 32 additions & 11 deletions

File tree

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
## [Unreleased]
99

10+
## [v5.1.8-4] - 2025-11-27
11+
### Fixed
12+
- [#166] improve stability of background user deletion script for temp admins
13+
- backport to redmine 5
14+
1015
## [v5.1.8-3] - 2025-08-06
1116
### Security
1217
- [#155] close CVE GHSA-353f-x4gh-cqq8

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
FROM registry.cloudogu.com/official/base:3.19.4-3
22

33
LABEL NAME="official/redmine" \
4-
VERSION="5.1.8-3" \
4+
VERSION="5.1.8-4" \
55
maintainer="hello@cloudogu.com"
66

77
ENV USER=redmine \

docs/gui/release_notes_de.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,14 @@ Technische Details zu einem Release finden Sie im zugehörigen [Changelog](https
66

77
## [Unreleased]
88

9+
## [v5.1.8-4] - 2025-11-27
10+
### Fixed
11+
* Robustheit des Löschvorgangs von temporären Admins erhöht.
12+
* In Fehlerfällen können temporäre Admin Accounts in einem vorherigen Startversuch schon gelöscht wurden sein.
13+
* Während der damit verbundene Schlüssel in der Konfiguration darauf hingewiesen hat das ein solcher Account noch existiert.
14+
* Nachfolgende Löschversuche würden demnach fehlschlagen und die Konfiguration nicht richtig aufgeräumt werden, welches den Start des Dogu's verhindert.
15+
* Dieses Release behebt diesen Fehler.
16+
917
## [v5.1.8-3] - 2025-08-06
1018
### Changed
1119
* Wir haben nur technische Änderungen vorgenommen. Näheres finden Sie in den Changelogs.

docs/gui/release_notes_en.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,14 @@ Technical details on a release can be found in the corresponding [Changelog](htt
66

77
## [Unreleased]
88

9+
## [v5.1.8-4] - 2025-11-27
10+
### Fixed
11+
* Robustness of deletion process for temporary admins improved.
12+
* In Error Cases the temporary admin accounts were not properly deleted during a previous start attempt.
13+
* While the connected Configuration Key indicated that the admin account was not deleted yet.
14+
* Additional attempts at deleting this temporary account would fail and prevent proper Dogu Startup.
15+
* This Error was fixed with this Release.
16+
917
## [v5.1.8-3] - 2025-08-06
1018
### Changed
1119
* We have only made technical changes. You can find more details in the changelogs.

dogu.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"Name": "official/redmine",
3-
"Version": "5.1.8-3",
3+
"Version": "5.1.8-4",
44
"DisplayName": "Redmine",
55
"Description": "Redmine is a flexible project management web application",
66
"Category": "Development Apps",

resources/rails_scripts/remove_user.rb

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ def symbolize_keys!
2424
begin
2525
opts = RemoveUserHelper::options
2626
puts "Try to remove user %s" % opts[:username]
27-
user = User.where(login: opts[:username]).first
28-
puts 'User did not exist' if user.nil?
29-
user.destroy unless user.nil?
30-
puts 'User removed successfully.' unless user.nil?
31-
rescue Exception => error
32-
puts '====================================================='
33-
puts error.message
34-
puts '====================================================='
35-
puts 'User remove failed.'
27+
user = User.find_by_login(opts[:username])
28+
if user
29+
user.destroy!
30+
else
31+
puts "User did not exist"
32+
end
33+
rescue StandardError => e
34+
warn "User deletion failed: #{e.class}: #{e.message}"
35+
raise
3636
end

0 commit comments

Comments
 (0)