[BUG] Jotty: Data erased after update

[GFBOX]

✅ Have you read and understood the above guidelines?

yes

🔎 Did you run the script with verbose mode enabled?

Yes, verbose mode was enabled and the output is included below

📜 What is the name of the script you are using?

jotty

📂 What was the exact command used to execute the script?

update

⚙️ What settings are you using?

• Default Settings
• Advanced Settings

🖥️ Which Linux distribution are you using?

Debian 13

📈 Which Proxmox version are you on?

8.4.19

📝 Provide a clear and concise description of the issue.

`jotty LXC Container
🌐 Provided by: community-scripts ORG | GitHub: https://github.com/community-scripts/ProxmoxVE

🖥️   OS: Debian GNU/Linux - Version: 13
🏠   Hostname: notes
💡   IP Address: 192.168.45.69

✔️ Update available: jotty 1.21.0 → 1.23.0
✔️ Stopped Service
✔️ Backed up configuration & data
Hit:1 http://deb.debian.org/debian trixie InRelease
Hit:2 http://security.debian.org trixie-security InRelease
Hit:3 http://deb.debian.org/debian trixie-updates InRelease
Hit:4 https://deb.nodesource.com/node_22.x nodistro InRelease
All packages are up to date.
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
nodejs is already the newest version (22.22.2-1nodesource1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

removed 49 packages, and changed 92 packages in 25s

15 packages are looking for funding
run npm fund for details
✔️ Update Node.js 22
⏳ Updating yarn to latest version
changed 1 package in 5s
✔️ Installed Node.js modules: yarn
✔️ Deployed: jotty (1.23.0)
✔️ Restored configuration & data
✔️ Started Service
✔️ Updated successfully!`

🔄 Steps to reproduce the issue.

type 'update' to execute the script then go on the webui and it is like a fresh install, no previous data just the invite to create an admin account.

❌ Paste the full error output (if available).

none

🖼️ Additional context (optional).

I have tested the update 3 times with backup restore in between. I am not a dev and I don't know coding, I learned from all my fails so my apologies if something "obvious" to you is not for me.

1- initial try
=> failed => users data are missing
=> script does not update all the packages => good to know

2- backup folder /opt on my own and run apt update && apt upgrade before update
=> failed => users data still missing but /opt/data was present before update and missing after update. Looking at the script it looks like /opt/data is used to backup so being already there prevent the backup while the script has been executed without warning.

3- backup folder /opt on my own, run apt update && apt upgrade and remove folder /opt/data before update
=> success, update done and data are not missing this time.

I have never updated this app since I installed it, I don't know why the folder /opt/data was there. The issue is resolved but adding some lines in the script to prevent this behavior would be great.

[MickLesk]

@fccview Idea? Look Not Like an Script issue

[fccview]

I'd have heard it by now if there was a data issue upgrading jotty, latest version has more than 20k pulls 😬😅

I can look into it but I haven't experienced this nor I have had anyone opening issues/telling me about it

[fccview]

@GFBOX can you check if the data is actually gone or somehow permissions changed?

[GFBOX]

@fccview thank you for taking the time, like I said on my 3rd attempt the update worked perfectly.

The culprit was the folder /opt/data already there before the update, removing it manually before running update solved the issue. I still report the issue because I think that adding a check on the script about existant folder could prevent this issue. And like I said I have never updated this lxc until today nor touch it post installation so I don't know where this /opt/data come from.

Right now I'm on paperless with breaking change https://github.com/community-scripts/ProxmoxVE/pull/9223
Looks like not doing the update often is not a good idea...

[tremor021]

[[ -d /opt/data ]] && mv /opt/data /opt/jotty/data

You having /opt/data before update is a clear sign something was wrong with the install before you ran the update.
Our update script moves that directory to the proper location when running the update

[GFBOX]

@tremor021 I agree but I can't tell what was wrong since my jotty was working perfectly... only the update couldn't go through. Maybe I am an exception and no further control is needed, I am no expert nor dev, but a check on existing folder nor empty folder will not harm anyone I think. Indeed I checked my own backup and /opt/data was not empty before the update.

[vhsdream]

Actually @GFBOX you are right - after a fresh install the folder /opt/data is created:

@fccview is that the intended behaviour? When I then go on to create a user and start a checklist, a data folder is created in /opt/jotty and the one in /opt remains unused.

It's clear what then happens when running an update - the user data does get backed up, but then it's restored in /opt/jotty/data/data.

Edit: @fccview sorry to ping you again! This is not an issue with your prebuild - it's the install script. I'll fix it 😸

[fccview]

Edit: @fccview sorry to ping you again! This is not an issue with your prebuild - it's the install script. I'll fix it 😸

It's all good! I'm glad we got to the bottom of it ♥️