refactor(WIP): get rid of wavevision/props-control in favor of built-in nette controls

Author: rozsival

app/model/UI/BaseRenderControl.php

@@ -2,23 +2,31 @@
 
 namespace App\Model\UI;
 
+use Nette\Application\UI\Template;
 use Nette\Bridges\ApplicationLatte\DefaultTemplate;
-use Wavevision\PropsControl\BaseControl;
 
 /**
  * @property-read DefaultTemplate $template
  */
 abstract class BaseRenderControl extends BaseControl
 {
 
-	public function render(): void
+	protected const DEFAULT_TEMPLATE = 'default';
+
+	protected function createTemplate(): Template
 	{
-		$this->beforeRender();
-		$this->template->render();
+		$template = parent::createTemplate();
+		$template->setFile($this->getTemplateFile());
+		return $template;
 	}
 
-	protected function beforeRender(): void
+	final protected function getTemplateFile(?string $template = null): string
 	{
+		if (!$template) {
+			$template = static::DEFAULT_TEMPLATE;
+		}
+		$file = (string)$this->getReflection()->getFileName();
+		return dirname($file) . "/templates/$template.latte";
 	}
 
 }

app/modules/Front/Base/Controls/AddonList/Avatar/AvatarProps.php

@@ -2,14 +2,19 @@
 
 namespace App\Modules\Front\Base\Controls\AddonList\Avatar;
 
-use Wavevision\PropsControl\PropsControl;
+use App\Model\Database\ORM\Addon\Addon;
+use App\Model\UI\BaseRenderControl;
 
-class Control extends PropsControl
+class Control extends BaseRenderControl
 {
 
-	protected function getPropsClass(): string
+	public function render(Addon $addon, bool $linkToGitHub = false, bool $small = false): void
 	{
-		return AvatarProps::class;
+		$this->template->setParameters([
+			'addon' => $addon,
+			'linkToGitHub' => $linkToGitHub,
+			'small' => $small,
+		])->render();
 	}
 
 }

app/modules/Front/Base/Controls/AddonList/Avatar/Control.php

@@ -1,9 +1,9 @@
-{templateType Wavevision\PropsControl\PropsControlTemplate}
 {varType App\Model\Database\ORM\Addon\Addon $addon}
-{var $addon = $props->get(App\Modules\Front\Base\Controls\AddonList\Avatar\AvatarProps::ADDON)}
-<a href="{if $props->linkToGithub}{$addon->github->linker->getRepoUrl()}{else}{plink Addon:detail, slug => $addon->id}{/if}"
+{varType bool $linkToGithub}
+{varType bool $small}
+<a href="{if $linkToGithub}{$addon->github->linker->getRepoUrl()}{else}{plink Addon:detail, slug => $addon->id}{/if}"
    class="flex-shrink-0 mr-4"
 >
     <img loading="lazy" alt="{$addon->author}"
-         src="{avatar $addon->author}" n:class="'w-8 h-8 rounded-full', !$props->small ? 'lg:h-16 lg:w-16'">
+         src="{avatar $addon->author}" n:class="'w-8 h-8 rounded-full', !$small ? 'lg:h-16 lg:w-16'">
 </a>

app/modules/Front/Base/Controls/AddonList/Avatar/templates/default.latte

@@ -2,14 +2,15 @@
 
 namespace App\Modules\Front\Base\Controls\AddonList\Description;
 
-use Wavevision\PropsControl\PropsControl;
+use App\Model\Database\ORM\Addon\Addon;
+use App\Model\UI\BaseRenderControl;
 
-class Control extends PropsControl
+class Control extends BaseRenderControl
 {
 
-	protected function getPropsClass(): string
+	public function render(Addon $addon): void
 	{
-		return DescriptionProps::class;
+		$this->template->setParameters(['addon' => $addon])->render();
 	}
 
 }

app/modules/Front/Base/Controls/AddonList/Description/Control.php

@@ -1,2 +1,2 @@
-{templateType Wavevision\PropsControl\PropsControlTemplate}
-<p class="text-sm text-gray-700">{$props->addon->github->description|truncate:150|striptags|emojify|noescape}</p>
+{varType App\Model\Database\ORM\Addon\Addon $addon}
+<p class="text-sm text-gray-700">{$addon->github->description|truncate:150|striptags|emojify|noescape}</p>

app/modules/Front/Base/Controls/AddonList/Description/DescriptionProps.php

@@ -4,29 +4,21 @@
 
 use App\Model\Database\ORM\Addon\Addon;
 use App\Model\Database\ORM\GithubRelease\GithubRelease;
-use App\Model\UI\BasePropsControl;
+use App\Model\UI\BaseRenderControl;
 use Nextras\Orm\Collection\ICollection;
-use Wavevision\PropsControl\ValidProps;
 
-class Control extends BasePropsControl
+class Control extends BaseRenderControl
 {
 
-	protected function getPropsClass(): string
+	public function render(Addon $addon, bool $linkToGitHub = false, bool $inverseTag = false): void
 	{
-		return NameProps::class;
-	}
-
-	protected function beforeRender(ValidProps $props): void
-	{
-		parent::beforeRender($props);
-		/** @var Addon $addon */
-		$addon = $props->get(NameProps::ADDON);
-		$this->template->setParameters(['addon' => $addon]);
+		$this->template->setParameters(['addon' => $addon, 'linkToGitHub' => $linkToGitHub, 'inverseTag' => $inverseTag]);
 		if ($github = $addon->github) {
 			/** @var GithubRelease|null $release */
 			$release = $github->releases->get()->orderBy(['crawledAt' => ICollection::DESC])->fetch();
 			$this->template->setParameters(['release' => $release]);
 		}
+		$this->template->render();
 	}
 
 }

app/modules/Front/Base/Controls/AddonList/Description/templates/default.latte

@@ -1,8 +1,9 @@
-{templateType Wavevision\PropsControl\PropsControlTemplate}
 {varType App\Model\Database\ORM\Addon\Addon $addon}
 {varType App\Model\Database\ORM\GithubRelease\GithubRelease|null $release}
+{varType bool $linkToGitHub}
+{varType bool $inverseTag}
 <h3 class="inline-block mb-2 text-lg font-bold leading-tight text-teal-800 font-headers xl:text-xl align-middle">
-    {if $props->linkToGithub}
+    {if $linkToGitHub}
         <a data-ga="1" data-event="click" data-category="header" data-action="repo-author"
            title="Show all addons by {$addon->author}" href="{plink Index:author, slug => $addon->author}"
         >
@@ -19,7 +20,7 @@
             {$addon->author} / {$addon->name}
         </a>
     {/if}
-    <span n:if="$release" n:class="'relative inline-block px-2 text-sm font-normal text-blue-700 rounded-full -mt-1 align-middle', $props->inverseTag ? 'bg-white' :'bg-blue-100'">
+    <span n:if="$release" n:class="'relative inline-block px-2 text-sm font-normal text-blue-700 rounded-full -mt-1 align-middle', $inverseTag ? 'bg-white' :'bg-blue-100'">
         {$release->tag}
     </span>
 </h3>