external rofi plugins/modes increase ram when switching

[zspher]

Hi, I've noticed an increase in ram when switching (ctrl+tab) with extenal rofi plugins (i.e. rofi-calc, my own plugin). The ram increase does not happen when using internal rofi modes (i.e. drun,keys)

2026-03-06.11-18-17.mp4

ram use from spamming ctrl+tab with rofi-calc

I'm not sure if this is a bug on how I implement my plugin, how I load plugins or a bug in rofi.
I've loaded plugins via rofi -plugin-path

Can someone else check if this happens on their system?

[DaveDavenport]

plugins are handled identical to internal modes once loaded.
I cannot directly come up with an idea why an plugin would cause a leak (from rofi perspective).

You could try running valgrind on it (with massif?)

[zspher]

[DaveDavenport]

hmm I think I managed to reproduce it.. I don't understand what this profiler sais (mmap'ed memory).

Thanks for the thorough report.

[DaveDavenport]

I think it might be caused when the window size changes.
In my first test I had a theme that does not do that.. returning to default theme does.
I get the leak in 'mmap', from 'display_buffer_pool_new'.

@lbonn do you have an idea on this?

[DaveDavenport]

Can you try the following patch?

diff --git a/source/wayland/display.c b/source/wayland/display.c
index db2d45ed..12937ed4 100644
--- a/source/wayland/display.c
+++ b/source/wayland/display.c
@@ -65,8 +65,8 @@
 #endif
 #include "keyboard-shortcuts-inhibit-unstable-v1-protocol.h"
 #include "primary-selection-unstable-v1-protocol.h"
-#include "wlr-layer-shell-unstable-v1-protocol.h"
 #include "text-input-unstable-v3-protocol.h"
+#include "wlr-layer-shell-unstable-v1-protocol.h"

 #define wayland_output_get_dpi(output, scale, dimension)                       \
   ((output)->current.physical_##dimension > 0 && (scale) > 0                   \
@@ -204,6 +204,8 @@ wayland_buffer_pool *display_buffer_pool_new(gint width, gint height) {

   wayland_buffer_pool *pool;
   pool = g_new0(wayland_buffer_pool, 1);
+  pool->data = data;
+  pool->size = pool_size;

[zspher]

sure, I'll test it out when I get back home.
thanks for looking into this

[DaveDavenport]

to confirm it is not plugins:

rofi  -modi "drun,filebrowser" -show drun -no-config -no-plugins

shows leak too

[zspher]

thanks, the above patch works for my plugin, rofi-calc and linkding.
doesn't work for rofi-calc but thats pobably because the plugin doesn't free all the data
edit: made some changes to rofi-calc so pls disregaurd

I've tested this on the latest rof-dev 89c768c

[lbonn]

Can you try the following patch?

diff --git a/source/wayland/display.c b/source/wayland/display.c
index db2d45ed..12937ed4 100644
--- a/source/wayland/display.c
+++ b/source/wayland/display.c
@@ -65,8 +65,8 @@
 #endif
 #include "keyboard-shortcuts-inhibit-unstable-v1-protocol.h"
 #include "primary-selection-unstable-v1-protocol.h"
-#include "wlr-layer-shell-unstable-v1-protocol.h"
 #include "text-input-unstable-v3-protocol.h"
+#include "wlr-layer-shell-unstable-v1-protocol.h"

 #define wayland_output_get_dpi(output, scale, dimension)                       \
   ((output)->current.physical_##dimension > 0 && (scale) > 0                   \
@@ -204,6 +204,8 @@ wayland_buffer_pool *display_buffer_pool_new(gint width, gint height) {

   wayland_buffer_pool *pool;
   pool = g_new0(wayland_buffer_pool, 1);
+  pool->data = data;
+  pool->size = pool_size;

Wow! Thanks, this was a pretty big one