Skip to content

Commit a76579a

Browse files
authored
Remove unactionable info from reviewer agent (#13578)
### Context @jankratochvilcz was pointing two friction points with pr-reviewer: - Non actionable comments - e.g. #13573 (comment) - The overviw table containing numerous 'LGTM' rows - which reduces 'signal-to-noise' ratio ### Changes Guiding to reduce nonactionable outputs cc @jankratochvilcz
2 parents 41c77a9 + 1cc7dc0 commit a76579a

1 file changed

Lines changed: 18 additions & 5 deletions

File tree

.github/agents/expert-reviewer.agent.md

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -646,24 +646,37 @@ Use this to prioritize dimensions based on changed files.
646646

647647
**Important**: Use `create_pull_request_review_comment` (inline on diff), NOT `add_comment` (general PR comment). Only findings tied to a specific changed line should use this tool.
648648

649+
**Every inline comment must be actionable.** Do NOT post comments that only praise existing code, acknowledge good patterns, or say "looks good". If a dimension is clean, do not leave an inline comment for it and do not add it as an LGTM row in the summary table; instead, count it only in the aggregate clean-dimensions summary line described in step 7. Comments like "This is well-written 👍" or "Good use of X pattern" add noise without giving the author anything to act on.
650+
649651
6. Post design-level concerns (not tied to a specific diff line) as a single PR comment via the `add_comment` safe-output tool — one bullet each.
650652

651653
### Wave 4: Summary
652654

653-
7. Submit the final review verdict via the `submit_pull_request_review` safe-output tool. Include the summary table in the review `body` and set the `event` field:
655+
7. Submit the final review verdict via the `submit_pull_request_review` safe-output tool. Include the summary table in the review `body` and set the `event` field.
656+
657+
**Omit all LGTM dimensions from the table** — only list dimensions that have findings. This keeps the review concise and actionable. Show the count of clean dimensions as a single summary line instead.
658+
659+
When there **are** findings:
654660

655661
```markdown
656662
| # | Dimension | Verdict |
657663
|---|-----------|---------|
658-
| 1 | Backwards Compatibility | ✅ LGTM |
659664
| 13 | Concurrency | 🔴 2 MAJOR |
665+
| 22 | Correctness | 🟡 1 MODERATE |
666+
667+
✅ 22/24 dimensions clean.
660668

661-
- [x] Backwards Compat
662669
- [ ] Concurrency — shared state race
670+
- [ ] Correctness — null input edge case
671+
```
672+
673+
When **all dimensions are clean**, omit the table entirely:
674+
675+
```markdown
676+
✅ 24/24 dimensions clean — no findings.
663677
```
664678

665-
`[x]` = LGTM or NITs only. `[ ]` = BLOCKING.
666-
Any BLOCKING → event: **REQUEST_CHANGES**. Otherwise (including all-clear) → event: **COMMENT**.
679+
`[ ]` = dimensions with findings. Any BLOCKING → event: **REQUEST_CHANGES**. Otherwise (including all-clear) → event: **COMMENT**.
667680
**Never use APPROVE** — the agent must not count as a PR approval.
668681

669682
All inline comments from step 5 are automatically bundled into this review submission.

0 commit comments

Comments
 (0)