Merge pull request #997 from epiforecasts/ordinal-tolerance

Allow for numeric imprecision for ordinal forecasts

Author: nikosbosse

NEWS.md

@@ -1,8 +1,8 @@
 # scoringutils (development version)
 
+- Added tolerance for numeric errors when checking that probabilities sum to one in ordinal forecasts (#997)
 - Made computation of p-values optional in pairwise comparisons by allowing `test_type = NULL` in `compare_forecasts()`. When `test_type = NULL`, p-values will be `NA` (#978).
 
-
 # scoringutils 2.1.0
 
 Minor spelling / mathematical updates to Scoring rule vignette. (#969)

R/metrics-nominal.R

@@ -72,9 +72,11 @@ assert_input_categorical <- function(
     assert_matrix(predicted, nrows = n)
     summed_predictions <- round(rowSums(predicted, na.rm = TRUE), 10) # avoid numeric errors
   }
-  if (!all(summed_predictions == 1)) {
+  # Allow for numeric errors
+  invalid_rows <- abs(summed_predictions - 1) > 1e-4
+  if (any(invalid_rows)) {
     #nolint start: keyword_quote_linter object_usage_linter
-    row_indices <- as.character(which(summed_predictions != 1))
+    row_indices <- which(invalid_rows)
     cli_abort(
       c(
         `!` = "Probabilities belonging to a single forecast must sum to one",