Skip to content

Commit 00e3ab4

Browse files
authored
Code Quality: Use FileExtensionHelpers.IsRichTextFile for RTF (#18153)
1 parent a0f22a3 commit 00e3ab4

3 files changed

Lines changed: 11 additions & 4 deletions

File tree

src/Files.App/ViewModels/UserControls/InfoPaneViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ private async Task<UserControl> GetBuiltInPreviewControlAsync(ListedItem item, b
324324
return new HtmlPreview(model);
325325
}*/
326326

327-
if (RichTextPreviewViewModel.ContainsExtension(ext))
327+
if (FileExtensionHelpers.IsRichTextFile(ext))
328328
{
329329
var model = new RichTextPreviewViewModel(item);
330330
await model.LoadAsync();

src/Files.App/ViewModels/UserControls/Previews/RichTextPreviewViewModel.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ public sealed partial class RichTextPreviewViewModel : BasePreviewModel
1212

1313
public RichTextPreviewViewModel(ListedItem item) : base(item) { }
1414

15-
public static bool ContainsExtension(string extension)
16-
=> extension is ".rtf";
17-
1815
public async override Task<List<FileProperty>> LoadPreviewAndDetailsAsync()
1916
{
2017
Stream = await Item.ItemFile.OpenReadAsync();

src/Files.Shared/Helpers/FileExtensionHelpers.cs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,5 +327,15 @@ public static bool IsTextFile(string? fileExtensionToCheck)
327327
{
328328
return HasExtension(fileExtensionToCheck, ".txt");
329329
}
330+
331+
/// <summary>
332+
/// Check if the file extension is a rich text file.
333+
/// </summary>
334+
/// <param name="fileExtensionToCheck"></param>
335+
/// <returns><c>true</c> if the fileExtensionToCheck is a rich text file; otherwise, <c>false</c>.</returns>
336+
public static bool IsRichTextFile(string? fileExtensionToCheck)
337+
{
338+
return HasExtension(fileExtensionToCheck, ".rtf");
339+
}
330340
}
331341
}

0 commit comments

Comments
 (0)