fix: avoid duplicate ModelNotFoundException logs on orphaned queued jobs (#4634)

When a queued job's serialized model is deleted between dispatch and
worker pickup, Laravel's CallQueuedHandler catches the unserialize
ModelNotFoundException via handleModelNotFound. Without
deleteWhenMissingModels, it then routes the job to fail(), which
re-deserializes the payload and throws ModelNotFoundException a second
time — this one is not caught and gets logged.

Set deleteWhenMissingModels = true on AbstractJob so the handler
delete()s the job (already off the queue, lock already released) instead
of going through the noisy fail() path. All current AbstractJob
subclasses (notification fan-out, mail sends, search index, package
manager, gdpr export, etc.) are no-ops when their subject model is
missing — there's no useful retry path.

Subclasses that genuinely want to be retried/failed on missing models
can override with `public bool $deleteWhenMissingModels = false;`.

Fixes #4615

Author: imorland

framework/core/src/Queue/AbstractJob.php

@@ -19,4 +19,16 @@ class AbstractJob implements ShouldQueue
     use InteractsWithQueue;
     use Queueable;
     use SerializesModels;
+
+    /**
+     * If a serialized model on this job has been deleted between dispatch and
+     * worker pickup, treat the job as a no-op and remove it from the queue
+     * rather than calling failed(), which re-deserializes the payload and
+     * throws ModelNotFoundException a second time — producing duplicate error
+     * log entries for what is in fact a handled-correctly race.
+     *
+     * Subclasses that should be retried or marked failed in this scenario can
+     * override with `public bool $deleteWhenMissingModels = false;`.
+     */
+    public bool $deleteWhenMissingModels = true;
 }