fix(settings): register missing defaults for admin dropdown settings (#4491)

maintenance_mode, slug_driver_Flarum\Discussion\Discussion, and
fontawesome_source were absent from flarum.settings.default, so
DefaultSettingsRepository::all() omitted them on installs where the
DB row had never been written (e.g. upgrades). The admin dropdowns
rendered empty as a result.

Closes #4488

Author: imorland

framework/core/src/Settings/SettingsServiceProvider.php

@@ -25,6 +25,10 @@ public function register(): void
                 'theme_primary_color' => '#4D698E',
                 'theme_secondary_color' => '#4D698E',
                 'mail_format' => 'multipart',
+                'fontawesome_source' => 'local',
+                'maintenance_mode' => 'none',
+                'slug_driver_Flarum\Discussion\Discussion' => 'default',
+                'slug_driver_Flarum\User\User' => 'default',
                 'search_driver_Flarum\User\User' => 'default',
                 'search_driver_Flarum\Discussion\Discussion' => 'default',
                 'search_driver_Flarum\Group\Group' => 'default',

framework/core/tests/integration/settings/DefaultSettingsTest.php

@@ -0,0 +1,60 @@
+<?php
+
+/*
+ * This file is part of Flarum.
+ *
+ * For detailed copyright and license information, please view the
+ * LICENSE file that was distributed with this source code.
+ */
+
+namespace Flarum\Tests\integration\settings;
+
+use Flarum\Discussion\Discussion;
+use Flarum\Testing\integration\TestCase;
+use Flarum\User\User;
+use Illuminate\Support\Collection;
+use PHPUnit\Framework\Attributes\Test;
+
+/**
+ * Tests that settings which power admin dropdowns are registered in
+ * flarum.settings.default, so they appear in SettingsRepositoryInterface::all()
+ * and reach the admin frontend payload on any install — including upgrades
+ * where WriteSettings never ran for newer settings.
+ *
+ * @see https://github.com/flarum/framework/issues/4488
+ */
+class DefaultSettingsTest extends TestCase
+{
+    private function defaults(): Collection
+    {
+        return $this->app()->getContainer()->make('flarum.settings.default');
+    }
+
+    #[Test]
+    public function maintenance_mode_has_a_registered_default(): void
+    {
+        $this->assertTrue($this->defaults()->has('maintenance_mode'));
+        $this->assertSame('none', $this->defaults()->get('maintenance_mode'));
+    }
+
+    #[Test]
+    public function slug_driver_for_discussion_has_a_registered_default(): void
+    {
+        $this->assertTrue($this->defaults()->has('slug_driver_'.Discussion::class));
+        $this->assertSame('default', $this->defaults()->get('slug_driver_'.Discussion::class));
+    }
+
+    #[Test]
+    public function slug_driver_for_user_has_a_registered_default(): void
+    {
+        $this->assertTrue($this->defaults()->has('slug_driver_'.User::class));
+        $this->assertSame('default', $this->defaults()->get('slug_driver_'.User::class));
+    }
+
+    #[Test]
+    public function fontawesome_source_has_a_registered_default(): void
+    {
+        $this->assertTrue($this->defaults()->has('fontawesome_source'));
+        $this->assertSame('local', $this->defaults()->get('fontawesome_source'));
+    }
+}