Merge pull request #54 from flightaware/FT-10969

Fix memory leak in build_param_array and in expand_parameters

Author: benburwell

.github/workflows/mac-ci.yml

@@ -16,12 +16,12 @@ jobs:
     - name: Install dependencies
       run: |
         brew update
-        brew install tcl-tk autoconf libpq
+        brew install tcl-tk@8 autoconf libpq
     - name: configure
       run: |       
         autoreconf -vi
         export PG_CONFIG=/opt/homebrew/opt/libpq/bin/pg_config
-        ./configure --with-tcl=/opt/homebrew/opt/tcl-tk/lib/ --prefix=/usr/local        
+        ./configure --with-tcl=/opt/homebrew/opt/tcl-tk@8/lib/ --prefix=/usr/local        
     - name: make
       run: make
     - name: install

configure.in

@@ -19,7 +19,7 @@ dnl	to configure the system for the local environment.
 # so you can encode the package version directly into the source files.
 #-----------------------------------------------------------------------
 
-AC_INIT([pgtcl], [3.1.0])
+AC_INIT([pgtcl], [3.1.1])
 
 #-----
 # Version with patch stripped

generic/pgtclCmds.c

@@ -629,6 +629,7 @@ int build_param_array(Tcl_Interp *interp, int nParams, Tcl_Obj *CONST objv[], co
 	}
 
 	*paramValuesPtr = paramValues;
+	ckfree(paramLengths);
 
 	return TCL_OK;
 }
@@ -2927,6 +2928,7 @@ static int expand_parameters(Tcl_Interp *interp, const char *queryString, int nP
 	// Normal return, push parameters and return OK.
 	*paramValuesPtr = paramValues;
 	*newQueryStringPtr = newQueryString;
+	ckfree(paramLengths);
 	return TCL_OK;
 
 error_return: