Skip to content

Commit e3c51e9

Browse files
committed
Some tidyups
1 parent 9784fb9 commit e3c51e9

1 file changed

Lines changed: 8 additions & 9 deletions

File tree

Source/NSHost.m

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -394,9 +394,9 @@ - (void) _addHostInfo: (NSString*)name
394394
a = [NSString stringWithUTF8String: ipstr];
395395
[self _addHostAddress: a withNames: names addresses: addresses];
396396

397-
/* If we have a canonical name for the host, use it.
397+
/* If we have a canonical name for the host (initial entry), use it.
398398
*/
399-
if (tmp->ai_canonname && *tmp->ai_canonname
399+
if (tmp == entry && tmp->ai_canonname && *tmp->ai_canonname
400400
&& strcmp(tmp->ai_canonname, ptr) != 0)
401401
{
402402
NSString *s = [NSString stringWithUTF8String: tmp->ai_canonname];
@@ -441,7 +441,7 @@ - (void) _addHostAddress: (NSString*)address
441441
[addresses addObject: address];
442442
if (inet_pton(AF_INET, addr, &ip_addr) != 1)
443443
{
444-
/* This is not IPV4 so it must be IPV6 and getaddrinfo_r()
444+
/* This is not IPV4 so it must be IPV6 and gethostbyname_r()
445445
* does not reliably support that.
446446
*/
447447
#if defined(HAVE_GETADDRINFO)
@@ -504,15 +504,14 @@ - (void) _addHostName: (NSString*)name
504504
}
505505
#elif defined(HAVE_GETADDRINFO)
506506

507-
#if defined(HAVE_RESOLVE_H)
507+
#if defined(HAVE_RESOLV_H)
508508
static NSSet *
509-
dnsaliases(NSString *host, NSSet *names);
509+
dnsaliases(NSString *host, NSSet *names)
510510
{
511511
NSMutableSet *found = nil;
512512
unsigned char response[NS_PACKETSZ];
513513
extern int h_errno;
514514
const char *name;
515-
unsigned added = 0;
516515
int len;
517516

518517
if (NULL == (name = getName(host)))
@@ -599,12 +598,12 @@ - (void) _addHostName: (NSString*)name
599598
{
600599
[names addObject: name];
601600
[self _addHostInfo: name withNames: names addresses: addresses];
602-
#if defined(HAVE_RESOLVE_H)
601+
#if defined(HAVE_RESOLV_H)
603602
{
604603
NSSet *aliases = dnsaliases(name, names);
605604

606-
GS_FOR_IN(NSString*, name, aliases)
607-
[self _addHostInfo: name withNames: names addresses: addresses];
605+
GS_FOR_IN(NSString*, alias, aliases)
606+
[self _addHostInfo: alias withNames: names addresses: addresses];
608607
GS_END_FOR(aliases)
609608
}
610609
#endif

0 commit comments

Comments
 (0)