copilot review

Author: sezanzeb

backend/src/entities/project.ts

@@ -12,7 +12,7 @@ import { Team } from "./team";
 export class Project {
   @PrimaryGeneratedColumn()
   public readonly id!: number;
-  @ManyToOne(() => Team, { eager: true, onDelete: "SET NULL" })
+  @ManyToOne(() => Team, { eager: true, onDelete: "CASCADE" })
   @JoinColumn()
   public team!: Team;
   @Column({ length: 1024 })

backend/src/services/team-service.ts

@@ -122,7 +122,11 @@ export class TeamService implements ITeamService {
 
     const originalTeamUserIds = originalTeam?.userIds();
 
-    if (!originalTeamUserIds!.includes(user.id)) {
+    // TODO test that admins and members can change the title, but not othe users
+    if (
+      user.role !== UserRole.Root &&
+      !originalTeamUserIds!.includes(user.id)
+    ) {
       throw new Error("You are not a member of this team");
     }
 

docs/docs.md

@@ -76,7 +76,7 @@ services:
       # a tilt example
       - MARIADB_DATABASE=tilt
       - MARIADB_USER=tilt
-      # genereate a password, as this one is shown publicly
+      # generate a password, as this one is shown publicly
       # in this repository
       - MARIADB_PASSWORD=this_is_not_secure_generate_something
 

frontend/src/components/base/button.tsx

@@ -67,7 +67,7 @@ interface IButtonProps {
   primary?: boolean;
   loading?: boolean;
   color?: string;
-  style?: Record<string, any>;
+  style?: React.CSSProperties;
 }
 
 /**

frontend/src/components/pages/edit-team.tsx

@@ -158,7 +158,7 @@ export const EditTeam = ({
       }
       return false;
     },
-    [team, title, description, image, showNotification],
+    [team, title, description, image, showNotification, onChange],
   );
 
   const acceptUserToTeam = async (userToAccept: UserListDto) => {

frontend/src/components/pages/view-team.tsx

@@ -25,9 +25,9 @@ export const ViewTeam = () => {
     return team?.users?.some((u) => u.id === user?.id) ?? false;
   }, [team, user?.id]);
 
-  const reloadTeam = async () => {
+  const reloadTeam = React.useCallback(async () => {
     await api.getTeamByID(teamId).then((team_) => setTeam(team_));
-  };
+  }, []);
 
   const isAdmin = user?.role === UserRole.Root;