Use pre-commit to implement GHA basic checks (#9015)

* Add initial pre-commit configuration

* pre-commit: enable trailing-whitespace

* pre-commit: enable end-of-file-fixer

* pre-commit: enable check-executables-have-shebangs

* pre-commit: enable check-shebang-scripts-are-executable

* pre-commit: enable clang-format

* pre-commit: extend clang-format to Objective-C

* pre-commit: extend clang-format to JSON

* pre-commit: enable ruff-check

* pre-commit: enable ruff-format

This step was missing the GitHub Actions workflow.

* ruff: upgrade v0.15.0 to v0.15.5

* pre-commit: check test/**/CMakeLists.txt for missing sources

* pre-commit: enable taplo-format (TOML formatter)

* Deploy pre-commit on GitHub Actions

Author: alexreinking

.clang-format

@@ -38,3 +38,8 @@ Standard: c++17
 TabWidth: 8
 UseTab: Never
 ...
+---
+Language: Json
+IndentWidth: 2
+ColumnLimit: 0
+...

.devcontainer/devcontainer.json

@@ -33,4 +33,4 @@
   // Comment out to connect as the root user.
   "remoteUser": "ubuntu",
   "containerUser": "root"
-}
+}

…ithub/workflows/presubmit-clang-tidy.yml .github/workflows/clang-tidy.yml.github/workflows/presubmit-clang-tidy.yml renamed to .github/workflows/clang-tidy.yml .github/workflows/presubmit-clang-tidy.yml renamed to .github/workflows/clang-tidy.yml

@@ -8,7 +8,7 @@ on:
       - '**.cpp'
       - 'run-clang-tidy.sh'
       - '**.clang-tidy'
-      - '.github/workflows/presubmit-clang-tidy.yml'
+      - '.github/workflows/clang-tidy.yml'
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
@@ -33,4 +33,4 @@ jobs:
       - name: Run clang-tidy
         run: ./run-clang-tidy.sh
         env:
-          CLANG_TIDY_LLVM_INSTALL_DIR: /opt/homebrew/opt/llvm@21
+          CLANG_TIDY_LLVM_INSTALL_DIR: /opt/homebrew/opt/llvm@21

.github/workflows/pre-commit.yml

@@ -0,0 +1,23 @@
+name: Halide Presubmit Checks
+on:
+  # We don't want 'edited' (that's basically just the description, title, etc.)
+  # We don't want 'review_requested' (that's redundant to the ones below for our purposes)
+  pull_request:
+    types: [ opened, synchronize, reopened ]
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
+permissions:
+  contents: read
+
+jobs:
+  pre-commit:
+    name: Run pre-commit checks
+    runs-on: ubuntu-slim
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+      - uses: astral-sh/setup-uv@v5
+      - uses: pre-commit/action@v3.0.1

.github/workflows/presubmit.yml

@@ -81,7 +81,7 @@ jobs:
             brew install libjpeg-turbo libpng pkgconf protobuf "llvm@${LLVM_VERSION}" "lld@${LLVM_VERSION}"
             echo "LLVM_CONFIG=$(brew --prefix "llvm@${LLVM_VERSION}")/bin/llvm-config" | tee -a "$GITHUB_ENV"
           fi
-          
+
           uv sync --group ci-base --no-install-project
           echo "${GITHUB_WORKSPACE}/.venv/bin" | tee -a "$GITHUB_PATH"
           echo "VIRTUAL_ENV=${GITHUB_WORKSPACE}/.venv" | tee -a "$GITHUB_ENV"

.github/workflows/testing-make.yml

@@ -0,0 +1,79 @@
+exclude: ^dependencies/(spirv|vulkan)/
+
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v6.0.0
+    hooks:
+      - id: check-added-large-files
+      - id: check-case-conflict
+      - id: check-executables-have-shebangs
+      - id: check-json
+        exclude: ^\.devcontainer/
+      - id: check-merge-conflict
+      - id: check-shebang-scripts-are-executable
+      - id: check-symlinks
+      - id: check-yaml
+        args: [ --allow-multiple-documents ]
+      - id: destroyed-symlinks
+      - id: end-of-file-fixer
+        exclude: \.patch$
+      - id: fix-byte-order-marker
+      - id: mixed-line-ending
+      - id: no-commit-to-branch
+      - id: trailing-whitespace
+        args: [ --markdown-linebreak-ext=md ]
+        exclude: \.patch$
+
+  - repo: https://github.com/rhysd/actionlint
+    rev: v1.7.11
+    hooks:
+      - id: actionlint
+
+  - repo: https://github.com/pre-commit/mirrors-clang-format
+    rev: v21.1.8
+    hooks:
+      - id: clang-format
+        args: [ --sort-includes ]
+        types_or: [ c, c++, objective-c, json ]
+        exclude: |
+          (?x)(
+            ^tutorial/
+            | ^src/runtime/hexagon_remote/bin/src/
+            | ^src/runtime/mini_webgpu\.h$
+            | ^src/runtime/mini_d3d12\.h$
+            | ^src/runtime/vulkan_context\.h$
+            | \.fbs\.h$
+            | ^\.devcontainer/
+            | \.xcassets/
+          )
+
+  - repo: https://github.com/gitleaks/gitleaks
+    rev: v8.9.0
+    hooks:
+      - id: gitleaks
+
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.15.5
+    hooks:
+      - id: ruff-check
+      - id: ruff-format
+
+  - repo: https://github.com/ComPWA/taplo-pre-commit
+    rev: v0.9.3
+    hooks:
+      - id: taplo-format
+
+  - repo: local
+    hooks:
+      - id: check-cmake-file-lists
+        name: check CMake file lists
+        entry: python tools/check_cmake_file_lists.py
+        language: system
+        files: ^test/.*CMakeLists\.txt$
+
+      - id: uv-lock
+        name: check uv.lock is up to date
+        entry: uv lock --check
+        language: system
+        pass_filenames: false
+        files: ^(pyproject\.toml|uv\.lock)$

.pre-commit-config.yaml

@@ -52,7 +52,7 @@ that end, we have a few ground rules that we ask people to adhere to:
 - **Give credit where it's due.** If you use code or ideas from other people,
   projects, or publications, say so. Add a comment in the source code at the
   point where the idea is used. If adapting code, this requirement is above and
-  beyond any requirements placed on you by the license of the original code. 
+  beyond any requirements placed on you by the license of the original code.
   Additionally, any code generated by an AI tool (such as a large language model)
   must be clearly identified as such in the commit message using
   "Co-authored-by: The name of the tool". We all like recognition for our work.

CODE_OF_CONDUCT.md

@@ -230,4 +230,3 @@ the routine and comment the changes made to the original.
 We will gladly answer any questions regarding the software. If a modification is
 done, however, it is the responsibility of the person who modified the routine
 to provide support.
-

LICENSE.txt

@@ -14,4 +14,3 @@
 #  'key.store' for the location of your keystore and
 #  'key.alias' for the name of the key to use.
 # The password will be asked during the build when you use the 'release' target.
-