Skip to content

Commit cd9365a

Browse files
authored
Add a SKIP-WITH-ISSUE-#### (#9025)
Add a SKIP-WITH-ISSUE-#### regex to allow marking tests to be skipped because of an unresolved issue.
1 parent c07af18 commit cd9365a

7 files changed

Lines changed: 8 additions & 8 deletions

File tree

cmake/HalideTestHelpers.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ function(add_halide_test TARGET)
7777
PROPERTIES
7878
LABELS "${args_GROUPS}"
7979
ENVIRONMENT "HL_TARGET=${_resolved_target};HL_JIT_TARGET=${_resolved_target}"
80-
SKIP_REGULAR_EXPRESSION "\\[SKIP\\]"
80+
SKIP_REGULAR_EXPRESSION "\\[SKIP(-WITH-ISSUE(-[0-9]+)?)?\\]"
8181
WILL_FAIL ${args_EXPECT_FAILURE}
8282
)
8383
if ("multithreaded" IN_LIST args_GROUPS)

test/correctness/float16_t_neon_op_check.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,7 @@ class SimdOpCheck : public SimdOpCheckTest {
314314

315315
int main(int argc, char **argv) {
316316
// FIXME
317-
printf("[SKIP] Test is currently broken. See https://github.com/halide/Halide/issues/8083");
317+
printf("[SKIP-WITH-ISSUE-8083] Test is currently broken. See https://github.com/halide/Halide/issues/8083");
318318
return 0;
319319

320320
return SimdOpCheckTest::main<SimdOpCheck>(

test/correctness/gpu_allocation_cache.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ int main(int argc, char **argv) {
2121
}
2222
if (target.has_feature(Target::D3D12Compute)) {
2323
// https://github.com/halide/Halide/issues/5000
24-
printf("[SKIP] Allocation cache not yet implemented for D3D12Compute.\n");
24+
printf("[SKIP-WITH-ISSUE-5000] Allocation cache not yet implemented for D3D12Compute.\n");
2525
return 0;
2626
}
2727
if (target.has_feature(Target::Vulkan) && ((target.os == Target::IOS) || target.os == Target::OSX)) {

test/correctness/interpreter.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ int main(int argc, char **argv) {
99
if (target.os == Target::Windows &&
1010
(target.has_feature(Target::OpenCL) ||
1111
target.has_feature(Target::D3D12Compute))) {
12-
printf("[SKIP] workaround for issue #5738\n");
12+
printf("[SKIP-WITH-ISSUE-5738] workaround for issue #5738\n");
1313
return 0;
1414
}
1515

@@ -20,7 +20,7 @@ int main(int argc, char **argv) {
2020

2121
// Workaround for https://github.com/halide/Halide/issues/7420
2222
if (target.has_feature(Target::WebGPU)) {
23-
printf("[SKIP] workaround for issue #7420\n");
23+
printf("[SKIP-WITH-ISSUE-7420] workaround for issue #7420\n");
2424
return 0;
2525
}
2626

test/correctness/multi_way_select.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ using namespace Halide;
66
int main(int argc, char **argv) {
77
#if defined(__APPLE__) && defined(__x86_64__)
88
if (get_jit_target_from_environment().has_feature(Target::WebGPU)) {
9-
printf("[SKIP] This fails on x86 Macs (pre-Ventura) due to a bug in Apple's Metal Shading Language compiler. See https://github.com/halide/Halide/issues/7389.\n");
9+
printf("[SKIP-WITH-ISSUE-7389] This fails on x86 Macs (pre-Ventura) due to a bug in Apple's Metal Shading Language compiler. See https://github.com/halide/Halide/issues/7389.\n");
1010
return 0;
1111
}
1212
#endif

test/correctness/simd_op_check_wasm.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ class SimdOpCheckWASM : public SimdOpCheckTest {
538538

539539
int main(int argc, char **argv) {
540540
#ifdef HALIDE_INTERNAL_USING_ASAN
541-
printf("[SKIP] This test causes an ASAN crash relating to ASAN's use of sigaltstack. It doesn't seem to be due to a bug in the test itself (see https://github.com/halide/Halide/pull/8078#issuecomment-1935407878)");
541+
printf("[SKIP-WITH-ISSUE-8078] This test causes an ASAN crash relating to ASAN's use of sigaltstack. It doesn't seem to be due to a bug in the test itself (see https://github.com/halide/Halide/pull/8078#issuecomment-1935407878)");
542542
return 0;
543543
#endif
544544

test/performance/boundary_conditions.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ int main(int argc, char **argv) {
8787

8888
// Workaround for https://github.com/halide/Halide/issues/7420
8989
if (target.has_feature(Target::WebGPU)) {
90-
printf("[SKIP] workaround for issue #7420 (performance 2x as slow as expected)\n");
90+
printf("[SKIP-WITH-ISSUE-7420] workaround for issue #7420 (performance 2x as slow as expected)\n");
9191
return 0;
9292
}
9393

0 commit comments

Comments
 (0)