Skip to content

[CI] Trial Sourcery PR reviews #13452

@iwr-redmond

Description

@iwr-redmond

This is a followup to #13343 that continues to consider ways in which PRs can be managed more efficiently.

You may wish to consider trialing Sourcery PR reviews, which are free for open-source repositories. This would facilitate the automation of at least some first-stage PR reviews, while also allowing Diffusers team members to quickly ascertain whether PR authors are actively working on their code in response to feedback.

Sourcery reviews

Sourcery reviews include:

Security scanning is also available as a paid product, but that feature falls outside the scope of what I am proposing here.

I have collated a few recent examples that show what Sourcery produces versus Copilot and Gemini when reviewing PRs:

These examples suggest that Sourcery reviews generate more useful data than either Copilot or Gemini, which are both paid products.

Staged Implementation

As a starting point, you could enable the AI and rule based reviews, which are mostly set-and-forget one time setup tasks. If the basic setup goes well and proves useful, additional developer time could be used to develop custom quality rules that reflect Diffusers' coding standards. This might be informed by an analysis of recent third-party PRs to identify common problems with incoming code that could be identified using rule-based checks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions