Working on updating detail view w/ playadb

Author: chrisballinger

CLAUDE.md

@@ -89,6 +89,9 @@ xcodebuild test -workspace iBurn.xcworkspace -scheme iBurnTests -destination 'pl
 
 # Run PlayaKit tests
 xcodebuild test -workspace iBurn.xcworkspace -scheme PlayaKitTests -destination 'platform=iOS Simulator,name=iPhone 16 Pro,arch=arm64' -quiet
+
+# Run SPM tests (quietly by default)
+swift test --quiet
 ```
 
 **Utility Commands**:
@@ -121,9 +124,6 @@ xcrun simctl shutdown "iPhone 16 Pro"
 xcrun simctl erase "iPhone 16 Pro"
 ```
 
-
-
-
 ### Fastlane Commands
 - `fastlane ios beta` - Build and upload to TestFlight
 - `fastlane ios refresh_dsyms` - Download and upload crash symbols
@@ -134,7 +134,7 @@ When adding new functionality, make sure to plan for testability. When your feat
 
 - **Command Line**: Use xcodebuild test commands shown above for automated testing
 - **Xcode GUI**: Run tests through Xcode Test Navigator or `Cmd+U`  
-- **Test targets**: `iBurnTests`, `PlayaKitTests`
+- **Test targets**: `iBurnTests`, `PlayaKitTests`, and local Swift Package targets for `PlayaDB` and `PlayaAPI`
 
 ## Architecture Overview
 

Docs/2026-01-25-playadb-migration-next-steps.md

@@ -178,3 +178,52 @@ xcodebuild test -workspace iBurn.xcworkspace -scheme iBurnTests -destination 'pl
 - Users can browse Events using PlayaDB data (including correct cross-midnight occurrences) behind a feature flag.
 - Tapping an event can still route to the existing legacy detail flow until event detail is migrated.
 - The app continues to build and `xcodebuild test -scheme iBurnTests` continues to pass on simulator.
+
+---
+
+## Next Plan: Remove LegacyDataStore From SwiftUI List Navigation (Art/Camps)
+
+### Goal
+- SwiftUI Art/Camp lists should navigate (detail + map) without using YapDatabase-backed `LegacyDataStore` at all.
+- Allowed dependencies: PlayaDB (GRDB) + `BRCMediaDownloader` (filesystem/bundled media). Audio continues to use `BRCAudioPlayer` (now supports `BRCAudioTourTrack`).
+
+### Plan (Incremental)
+1) **Detail flow (PlayaDB-only)**
+   - Add new SwiftUI detail views for `PlayaDB.ArtObject` and `PlayaDB.CampObject`.
+   - Back them with a small view model that:
+     - reads `ObjectMetadata` via `PlayaDB.metadata(for:)`
+     - toggles favorites via `PlayaDB.toggleFavorite(_:)`
+     - loads thumbnail/audio URLs via `MediaAssetProviding` (`BRCMediaDownloader.localMediaURL`)
+     - optionally supports notes + lastViewed (requires PlayaDB API additions below)
+
+2) **Metadata write support**
+   - Extend `Packages/PlayaDB` public API with explicit metadata update methods (notes + lastViewed) so the app can persist those without reaching into GRDB internals.
+   - Add unit tests in `PlayaKitTests` or `iBurnTests` (whichever already hosts PlayaDB tests) that verify:
+     - notes round-trip
+     - lastViewed updates
+     - updatedAt changes appropriately
+
+3) **Map flow (PlayaDB-only)**
+   - Implement a new annotation type (e.g. `PlayaObjectAnnotation`) that conforms to `MLNAnnotation` + `ImageAnnotation` and is built from PlayaDB objects (uid, type, coordinate, title/subtitle).
+   - Enforce embargo via `BRCEmbargo.allowEmbargoedData()` (if embargoed, don’t show art/camp pins).
+
+4) **Map callout -> Detail**
+   - Update `MapViewAdapter` to:
+     - render `PlayaObjectAnnotation` using `LabelAnnotationView` (same look as legacy)
+     - route info-tap to the new detail flow via an injected closure/delegate (so we don’t call `DetailViewControllerFactory`).
+   - Defer share QR action for Playa objects until we have a PlayaDB-compatible share payload.
+
+5) **Replace LegacyDataStore usage**
+   - Update:
+     - `iBurn/ListView/ArtListHostingController.swift`
+     - `iBurn/ListView/CampListHostingController.swift`
+   - `onSelect`: push the new PlayaDB detail hosting controller.
+   - `onShowMap`: build `PlayaObjectAnnotation`s from the current filtered items and push `MapListViewController(dataSource: StaticAnnotationDataSource(annotations: ...))`.
+
+6) **Verification**
+   - Verify on iOS 26.2 sim:
+     - list -> detail works
+     - list -> map works
+     - map callout info -> detail works
+     - favorites + notes persist via PlayaDB
+     - embargo hides art/camp pins when locked

Packages/PlayaAPI/Sources/PlayaAPI/Models/Shared/Identifiers.swift

@@ -42,4 +42,4 @@ public typealias ArtID = ID<Art>
 public typealias CampID = ID<Camp>
 
 /// Strongly-typed identifier for Event objects
-public typealias EventID = ID<Event>
+public typealias EventID = ID<Event>

Packages/PlayaDB/Sources/PlayaDB/AnyDataObjectID.swift

@@ -0,0 +1,48 @@
+import Foundation
+import PlayaAPI
+
+/// A single identifier type that can represent any PlayaDB object identifier while
+/// preserving the underlying strongly-typed PlayaAPI IDs.
+///
+/// Useful for heterogeneous collections (e.g. map annotations, deep links, routing).
+public enum AnyDataObjectID: Hashable, Sendable, Codable {
+    case art(ArtID)
+    case camp(CampID)
+    case event(EventID)
+
+    public var objectType: DataObjectType {
+        switch self {
+        case .art: return .art
+        case .camp: return .camp
+        case .event: return .event
+        }
+    }
+
+    /// The raw uid string used by PlayaDB tables.
+    public var uid: String {
+        switch self {
+        case .art(let id): return id.value
+        case .camp(let id): return id.value
+        case .event(let id): return id.value
+        }
+    }
+
+    public init(objectType: DataObjectType, uid: String) {
+        switch objectType {
+        case .art:
+            self = .art(ArtID(uid))
+        case .camp:
+            self = .camp(CampID(uid))
+        case .event:
+            self = .event(EventID(uid))
+        }
+    }
+}
+
+public extension DataObject {
+    /// Converts a concrete PlayaDB model into a single sum-type identifier.
+    var anyID: AnyDataObjectID {
+        AnyDataObjectID(objectType: objectType, uid: uid)
+    }
+}
+

Packages/PlayaDB/Sources/PlayaDB/PlayaDB.swift

@@ -114,6 +114,12 @@ public protocol PlayaDB {
 
     /// Check if an object is favorited
     func isFavorite(_ object: any DataObject) async throws -> Bool
+
+    /// Update user notes for an object (nil/empty clears notes).
+    func setUserNotes(_ notes: String?, for object: any DataObject) async throws
+
+    /// Mark an object as viewed at the provided date (used for recents, etc.).
+    func setLastViewed(_ date: Date, for object: any DataObject) async throws
 
     // MARK: - Data Import
 

Packages/PlayaDB/Sources/PlayaDB/PlayaDBImpl.swift

@@ -984,6 +984,41 @@ internal class PlayaDBImpl: PlayaDB {
             return metadata?.isFavorite ?? false
         }
     }
+
+    func setUserNotes(_ notes: String?, for object: any DataObject) async throws {
+        try await ensureMetadata(for: object.objectType, ids: [object.uid])
+
+        try await dbQueue.write { db in
+            guard var metadata = try ObjectMetadata
+                .filter(ObjectMetadata.Columns.objectType == object.objectType.rawValue)
+                .filter(ObjectMetadata.Columns.objectId == object.uid)
+                .fetchOne(db) else {
+                throw PlayaDBError.metadataNotFound
+            }
+
+            let trimmed = notes?.trimmingCharacters(in: .whitespacesAndNewlines)
+            metadata.userNotes = (trimmed?.isEmpty == true) ? nil : trimmed
+            metadata.updatedAt = Date()
+            try metadata.update(db)
+        }
+    }
+
+    func setLastViewed(_ date: Date, for object: any DataObject) async throws {
+        try await ensureMetadata(for: object.objectType, ids: [object.uid])
+
+        try await dbQueue.write { db in
+            guard var metadata = try ObjectMetadata
+                .filter(ObjectMetadata.Columns.objectType == object.objectType.rawValue)
+                .filter(ObjectMetadata.Columns.objectId == object.uid)
+                .fetchOne(db) else {
+                throw PlayaDBError.metadataNotFound
+            }
+
+            metadata.lastViewed = date
+            metadata.updatedAt = Date()
+            try metadata.update(db)
+        }
+    }
 
     // MARK: - Data Import
 

Packages/PlayaDB/Sources/PlayaDB/TypedIdentifiers.swift

@@ -0,0 +1,19 @@
+import Foundation
+import PlayaAPI
+
+// Convenience typed identifiers for PlayaDB models.
+//
+// PlayaDB stores `uid` as a String for database/GRDB ergonomics, but the app often
+// wants strongly-typed IDs (from PlayaAPI) when routing/navigation crosses layers.
+
+extension ArtObject: Identifiable {
+    public var id: ArtID { ArtID(uid) }
+}
+
+extension CampObject: Identifiable {
+    public var id: CampID { CampID(uid) }
+}
+
+extension EventObject: Identifiable {
+    public var id: EventID { EventID(uid) }
+}

Packages/PlayaDB/Tests/PlayaDBTests/AnyDataObjectIDTests.swift

@@ -0,0 +1,30 @@
+import XCTest
+@testable import PlayaDB
+import PlayaAPI
+
+final class AnyDataObjectIDTests: XCTestCase {
+    func testInitFromObjectTypeAndUID() {
+        XCTAssertEqual(AnyDataObjectID(objectType: .art, uid: "a").uid, "a")
+        XCTAssertEqual(AnyDataObjectID(objectType: .camp, uid: "c").uid, "c")
+        XCTAssertEqual(AnyDataObjectID(objectType: .event, uid: "e").uid, "e")
+    }
+
+    func testRoundTripCodable() throws {
+        let values: [AnyDataObjectID] = [
+            .art(ArtID("a1")),
+            .camp(CampID("c1")),
+            .event(EventID("e1")),
+        ]
+
+        let data = try JSONEncoder().encode(values)
+        let decoded = try JSONDecoder().decode([AnyDataObjectID].self, from: data)
+        XCTAssertEqual(decoded, values)
+    }
+
+    func testUIDAndObjectType() {
+        let id = AnyDataObjectID.art("abc")
+        XCTAssertEqual(id.uid, "abc")
+        XCTAssertEqual(id.objectType, .art)
+    }
+}
+

Packages/PlayaDB/Tests/PlayaDBTests/MetadataUpdateTests.swift

@@ -0,0 +1,46 @@
+import XCTest
+@testable import PlayaDB
+import PlayaAPITestHelpers
+
+final class MetadataUpdateTests: XCTestCase {
+    private var playaDB: PlayaDB!
+
+    override func setUp() async throws {
+        try await super.setUp()
+        playaDB = try PlayaDBImpl(dbPath: ":memory:")
+
+        try await playaDB.importFromData(
+            artData: MockAPIData.artJSON,
+            campData: MockAPIData.campJSON,
+            eventData: MockAPIData.eventJSON
+        )
+    }
+
+    override func tearDown() async throws {
+        playaDB = nil
+        try await super.tearDown()
+    }
+
+    func testSetUserNotesRoundTrip() async throws {
+        let arts = try await playaDB.fetchArt()
+        let art = try XCTUnwrap(arts.first)
+
+        try await playaDB.setUserNotes("hello", for: art)
+        let metadata1 = try await playaDB.metadata(for: art)
+        XCTAssertEqual(metadata1.userNotes, "hello")
+
+        try await playaDB.setUserNotes("", for: art)
+        let metadata2 = try await playaDB.metadata(for: art)
+        XCTAssertNil(metadata2.userNotes)
+    }
+
+    func testSetLastViewedUpdatesMetadata() async throws {
+        let arts = try await playaDB.fetchArt()
+        let art = try XCTUnwrap(arts.first)
+
+        let date = Date(timeIntervalSince1970: 123)
+        try await playaDB.setLastViewed(date, for: art)
+        let metadata = try await playaDB.metadata(for: art)
+        XCTAssertEqual(metadata.lastViewed, date)
+    }
+}

Packages/PlayaDB/Tests/PlayaDBTests/PlayaDBImportTests.swift

@@ -250,8 +250,8 @@ final class PlayaDBImportTests: XCTestCase {
         let campData = MockAPIData.campJSON
         let eventData = MockAPIData.eventJSON
         let parser = APIParserFactory.create()
-        let expectedEventObjects = try parser.parseEvents(from: eventData)
-        // let totalExpectedOccurrences = expectedEventObjects.reduce(0) { $0 + $1.occurrenceSet.count }
+        _ = try parser.parseEvents(from: eventData)
+        // Note: we currently don't assert occurrence counts here; this parse call just sanity-checks the fixture.
 
         // When: Import data into PlayaDB
         try await playaDB.importFromData(artData: artData, campData: campData, eventData: eventData)
@@ -388,4 +388,4 @@ final class PlayaDBImportTests: XCTestCase {
             XCTAssertGreaterThan(eventObject.year, 0, "Event object should have valid year")
         }
     }
-}
+}