Skip to content

Commit 971ef20

Browse files
authored
Merge pull request #38 from joncloud/upgrade-versions
Updates version support for the action
2 parents 1c9f4bf + f7cba39 commit 971ef20

14 files changed

Lines changed: 1219 additions & 2191 deletions

File tree

.github/workflows/node.js.yml

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,18 @@ jobs:
1313

1414
strategy:
1515
matrix:
16-
os: [ 'windows-latest', 'ubuntu-latest', 'macos-latest' ]
17-
node-version: [20.x]
16+
os: [ 'windows-latest', 'windows-2025', 'ubuntu-latest', 'macos-latest' ]
17+
node-version: [ 20.x, 22.x, 24.x ]
1818

1919
steps:
20-
- uses: actions/checkout@v3
20+
- uses: actions/checkout@v5
2121

22-
- name: Use Node.js ${{ matrix.node-version }}
23-
uses: actions/setup-node@v3
24-
with:
25-
node-version: ${{ matrix.node-version }}
22+
- name: 'Setup pnpm'
23+
uses: pnpm/action-setup@v4
24+
25+
- name: 'Install makensis (choco)'
26+
run: choco install nsis
27+
if: ${{ matrix.os == 'windows-latest' || matrix.os == 'windows-2025' }}
2628

2729
- name: 'Install makensis (apt)'
2830
run: sudo apt update && sudo apt install -y nsis nsis-pluginapi
@@ -37,23 +39,30 @@ jobs:
3739
if: ${{ matrix.os == 'ubuntu-latest' }}
3840

3941
- name: 'Install npm dependencies'
40-
run: npm ci
42+
run: pnpm install
43+
44+
- name: 'Install Node.js'
45+
uses: actions/setup-node@v5
46+
with:
47+
node-version: ${{ matrix.node-version }}
48+
cache: 'pnpm'
4149

4250
- name: 'Test'
43-
run: npm test -- --reporter json --reporter-options output=${{ runner.temp }}/report-${{ matrix.os }}.json
51+
run: |
52+
pnpm test --reporter json --reporter-options output=${{ runner.temp }}/report-${{ matrix.os }}-${{ matrix.node-version }}.json
4453
4554
- name: 'Print Tests'
4655
# run this step even if previous step failed
4756
if: (success() || failure())
48-
run: cat ${{ runner.temp }}/report-${{ matrix.os }}.json | jq
57+
run: cat ${{ runner.temp }}/report-${{ matrix.os }}-${{ matrix.node-version }}.json | jq
4958

5059
- name: 'Publish Tests'
51-
uses: 'dorny/test-reporter@v1'
60+
uses: dorny/test-reporter@v2
5261
# run this step even if previous step failed
5362
if: ${{ !env.ACT }} && (success() || failure())
5463
# If this fails, don't worry the JSON output will be printed as a backup.
5564
continue-on-error: true
5665
with:
5766
name: 'test (${{ matrix.os }}, ${{ matrix.node-version }})'
58-
path: ${{ runner.temp }}/report-${{ matrix.os }}.json
67+
path: ${{ runner.temp }}/report-${{ matrix.os }}-${{ matrix.node-version }}.json
5968
reporter: mocha-json

.nvmrc

Lines changed: 0 additions & 1 deletion
This file was deleted.

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ Newline-delimited list of paths to load plugins from. Default `""`.
4141
4242
## Development
4343
44-
This action needs to be built from the source code located in the `/src` folder. Whenever you make changes, you should run the `npm run build` script. Otherwise, your changes won't be tested by CI.
44+
This action needs to be built from the source code located in the `/src` folder. Whenever you make changes, you should run the `pnpm build` script. Otherwise, your changes won't be tested by CI.
4545

4646
## Sample Projects
4747

action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@ inputs:
1717
default: ''
1818

1919
runs:
20-
using: 'node20'
21-
main: 'dist/index.cjs'
20+
using: node24
21+
main: dist/index.js
2222

2323
branding:
2424
icon: 'triangle'

dist/index.cjs

Lines changed: 0 additions & 8 deletions
This file was deleted.

dist/index.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)