Skip to content

Commit 42abe6e

Browse files
committed
Fix type of Creature referenceSources
This should have been Set<String> rather than Set<Source> since it is a unique collection of just the source name, without page references.
1 parent 16d5a25 commit 42abe6e

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

Sources/FifthEdition/Creature.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public struct Creature: Codable, Equatable, Sendable {
192192
public var sourceNote: String?
193193
public var page: Page?
194194
public var otherSources: Set<Source>?
195-
public var referenceSources: Set<Source>?
195+
public var referenceSources: Set<String>?
196196
public var additionalSources: Set<Source>?
197197
public var inSrd: SrdReference?
198198
public var inSrd52: SrdReference?

Tests/FifthEditionTests/Creature+CodableTests.swift

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,7 @@ struct CreatureCodableTests {
4545
"page": 38
4646
}
4747
],
48-
"referenceSources": [
49-
{
50-
"source": "XMM",
51-
"page": 42
52-
}
53-
],
48+
"referenceSources": [ "XMM" ],
5449
"size": [
5550
"H"
5651
],
@@ -175,7 +170,7 @@ struct CreatureCodableTests {
175170
source: "XMM",
176171
page: .number(42),
177172
otherSources: [.init(source: "MM", page: .number(38))],
178-
referenceSources: [.init(source: "XMM", page: .number(42))],
173+
referenceSources: ["XMM"],
179174
size: [.huge],
180175
type: .init(.type(.undead)),
181176
alignment: .alignment([.chaotic, .evil]),

0 commit comments

Comments
 (0)