Fixed the linting issues

Author: Vincent Hou

cmd/fetcher/main.go

@@ -122,7 +122,7 @@ func ensureRepo(ctx context.Context, known map[string][]packages.Release, client
 	}
 	if src.GitHub != (packages.GitHubSource{}) {
 		if client == nil {
-			return fmt.Errorf("must set $GITHUB_TOKEN to use github sources.")
+			return fmt.Errorf("must set $GITHUB_TOKEN to use github sources")
 		}
 		owner, repo := src.OrgRepo()
 		releases, err := github.GetReleases(ctx, client, owner, repo)
@@ -140,5 +140,5 @@ func ensureRepo(ctx context.Context, known map[string][]packages.Release, client
 		known[src.String()] = releases
 		return nil
 	}
-	return errors.New("Must specify one of S3 or GitHub")
+	return errors.New("must specify one of S3 or GitHub")
 }

pkg/blob/fetchers.go

@@ -79,7 +79,7 @@ func GetReleases(ctx context.Context, client *http.Client, cfg packages.S3Source
 			commonRepo = fields[0]
 		}
 		if fields[0] != commonRepo {
-			return nil, fmt.Errorf("Multiple repos listed in a single release source (%q and %q) in %s", fields[0], commonRepo, cfg)
+			return nil, fmt.Errorf("multiple repos listed in a single release source (%q and %q) in %s", fields[0], commonRepo, cfg)
 		}
 		rk := releaseKey{
 			repo: fields[0],

pkg/github/fetchers.go

@@ -34,7 +34,7 @@ func GetReleases(ctx context.Context, client *github.Client, org string, repo st
 		releases, resp, err := client.Repositories.ListReleases(ctx, org, repo, opt)
 		if err != nil || resp.StatusCode != 200 {
 			if err == nil {
-				err = fmt.Errorf("Got HTTP %d: %s", resp.StatusCode, resp.Status)
+				err = fmt.Errorf("got HTTP %d: %s", resp.StatusCode, resp.Status)
 			}
 			return nil, err
 		}

pkg/packages/release.go

@@ -214,18 +214,18 @@ func handlePrimary(ctx context.Context, base string, client *http.Client, p Pack
 		fileName := fmt.Sprintf("%d-%s", i+1, asset.Name)
 		file, err := os.OpenFile(filepath.Join(path, fileName), os.O_CREATE|os.O_WRONLY, 0644)
 		if err != nil {
-			return fmt.Errorf("Unable to open %s: %w", fileName, err)
+			return fmt.Errorf("unable to open %s: %w", fileName, err)
 		}
 		defer file.Close()
 		log.Print(asset.URL)
 		fetch, err := client.Get(asset.URL)
 		if err != nil {
-			return fmt.Errorf("Unable to fetch %s: %w", asset.URL, err)
+			return fmt.Errorf("unable to fetch %s: %w", asset.URL, err)
 		}
 		defer fetch.Body.Close()
 		_, err = io.Copy(file, fetch.Body)
 		if err != nil {
-			return fmt.Errorf("Unable to write to %s: %w", fileName, err)
+			return fmt.Errorf("unable to write to %s: %w", fileName, err)
 		}
 	}
 	return nil
@@ -269,18 +269,18 @@ func handleAlternatives(ctx context.Context, base string, client *http.Client, p
 			fileName := filepath.Join(resourcePath, a.Name)
 			file, err := os.OpenFile(fileName, os.O_CREATE|os.O_WRONLY, 0644)
 			if err != nil {
-				return fmt.Errorf("Unable to open %s: %w", fileName, err)
+				return fmt.Errorf("unable to open %s: %w", fileName, err)
 			}
 			defer file.Close()
 			log.Print(a.URL)
 			fetch, err := client.Get(a.URL)
 			if err != nil {
-				return fmt.Errorf("Unable to fetch %s: %w", a.URL, err)
+				return fmt.Errorf("unable to fetch %s: %w", a.URL, err)
 			}
 			defer fetch.Body.Close()
 			_, err = io.Copy(file, fetch.Body)
 			if err != nil {
-				return fmt.Errorf("Unable to write to %s: %w", fileName, err)
+				return fmt.Errorf("unable to write to %s: %w", fileName, err)
 			}
 		}
 	}

pkg/packages/release_test.go

@@ -185,7 +185,7 @@ func Test_assetList_FilterAssets(t *testing.T) {
 		{
 			name: "Rename bad",
 			f: func(s string) string {
-				return strings.Replace(s, "bad", "okay", -1)
+				return strings.ReplaceAll(s, "bad", "okay")
 			},
 			want: []Asset{
 				{Name: "test.yaml"},

pkg/reconciler/common/releases.go

@@ -115,11 +115,11 @@ func IsVersionValidMigrationEligible(instance base.KComponent) error {
 	}
 	target := SanitizeSemver(targetVersion)
 	if !semver.IsValid(target) {
-		return fmt.Errorf("target version %v is not in a valid semantic versioning format.", target)
+		return fmt.Errorf("target version %v is not in a valid semantic versioning format", target)
 	}
 
 	if len(strings.Split(target, ".")) < 2 {
-		return fmt.Errorf("target version %v should at least include the major and minor numbers.", target)
+		return fmt.Errorf("target version %v should at least include the major and minor numbers", target)
 	}
 
 	current := instance.GetStatus().GetVersion()
@@ -135,11 +135,11 @@ func IsVersionValidMigrationEligible(instance base.KComponent) error {
 
 	currentMinor, err := strconv.Atoi(strings.Split(current, ".")[1])
 	if err != nil {
-		return fmt.Errorf("minor number of the current version %v should be an integer.", current)
+		return fmt.Errorf("minor number of the current version %v should be an integer", current)
 	}
 	targetMinor, err := strconv.Atoi(strings.Split(target, ".")[1])
 	if err != nil {
-		return fmt.Errorf("minor number of the target version %v should be an integer.", target)
+		return fmt.Errorf("minor number of the target version %v should be an integer", target)
 	}
 
 	if currentMajor != targetMajor {
@@ -157,7 +157,7 @@ func IsVersionValidMigrationEligible(instance base.KComponent) error {
 		}
 
 		return fmt.Errorf("not supported to upgrade or downgrade across the MAJOR version. The "+
-			"installed KnativeServing version is %v.", current)
+			"installed KnativeServing version is %v", current)
 	}
 
 	// If the diff between minor versions are less than 2, return nil.
@@ -166,7 +166,7 @@ func IsVersionValidMigrationEligible(instance base.KComponent) error {
 	}
 
 	return fmt.Errorf("not supported to upgrade or downgrade across multiple MINOR versions. The "+
-		"installed KnativeServing version is %v.", current)
+		"installed KnativeServing version is %v", current)
 }
 
 type manifestFetcher func(string) (mf.Manifest, error)

pkg/reconciler/common/workload_override.go

@@ -22,7 +22,6 @@ import (
 	appsv1 "k8s.io/api/apps/v1"
 	batchv1 "k8s.io/api/batch/v1"
 	corev1 "k8s.io/api/core/v1"
-	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/client-go/kubernetes/scheme"
@@ -187,15 +186,15 @@ func replaceProbes(override *base.WorkloadOverride, ps *corev1.PodTemplateSpec)
 		for i := range containers {
 			override := findProbeOverride(override.ReadinessProbes, containers[i].Name)
 			if override != nil {
-				overrideProbe := &v1.Probe{
+				overrideProbe := &corev1.Probe{
 					InitialDelaySeconds:           override.InitialDelaySeconds,
 					TimeoutSeconds:                override.TimeoutSeconds,
 					PeriodSeconds:                 override.PeriodSeconds,
 					SuccessThreshold:              override.SuccessThreshold,
 					FailureThreshold:              override.FailureThreshold,
 					TerminationGracePeriodSeconds: override.TerminationGracePeriodSeconds,
 				}
-				if *overrideProbe == (v1.Probe{}) {
+				if *overrideProbe == (corev1.Probe{}) {
 					//  Disable probe when users explicitly set the empty overrideProbe.
 					containers[i].ReadinessProbe = nil
 					continue
@@ -213,15 +212,15 @@ func replaceProbes(override *base.WorkloadOverride, ps *corev1.PodTemplateSpec)
 		containers := ps.Spec.Containers
 		for i := range containers {
 			if override := findProbeOverride(override.LivenessProbes, containers[i].Name); override != nil {
-				overrideProbe := &v1.Probe{
+				overrideProbe := &corev1.Probe{
 					InitialDelaySeconds:           override.InitialDelaySeconds,
 					TimeoutSeconds:                override.TimeoutSeconds,
 					PeriodSeconds:                 override.PeriodSeconds,
 					SuccessThreshold:              override.SuccessThreshold,
 					FailureThreshold:              override.FailureThreshold,
 					TerminationGracePeriodSeconds: override.TerminationGracePeriodSeconds,
 				}
-				if *overrideProbe == (v1.Probe{}) {
+				if *overrideProbe == (corev1.Probe{}) {
 					//  Disable probe when users explicitly set the empty overrideProbe.
 					containers[i].LivenessProbe = nil
 					continue