Add e2e test

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Author: pierDipi

pkg/reconciler/common/transformers.go

@@ -84,6 +84,7 @@ func InjectNamespace(manifest *mf.Manifest, instance base.KComponent, extra ...m
 	return nil
 }
 
+// InjectLabel adds the given key and value as label.
 func InjectLabel(key, value string) mf.Transformer {
 	return func(u *unstructured.Unstructured) error {
 		curr := u.GetLabels()

pkg/reconciler/knativeeventing/controller.go

@@ -37,9 +37,12 @@ import (
 )
 
 const (
-	SelectorKey   = "app.kubernetes.io/name"
+	// SelectorKey is the key of the selector for the KnativeEventing resources.
+	SelectorKey = "app.kubernetes.io/name"
+	// SelectorValue is the value of the selector for the KnativeEventing resources.
 	SelectorValue = "knative-eventing"
-	Selector      = SelectorKey + "=" + SelectorValue
+	// Selector is the selector for the KnativeEventing resources.
+	Selector = SelectorKey + "=" + SelectorValue
 )
 
 // NewController initializes the controller and is called by the generated code

pkg/reconciler/knativeserving/controller.go

@@ -43,9 +43,12 @@ func NewController(ctx context.Context, cmw configmap.Watcher) *controller.Impl
 }
 
 const (
-	SelectorKey   = "app.kubernetes.io/name"
+	// SelectorKey is the key of the selector for the KnativeServing resources.
+	SelectorKey = "app.kubernetes.io/name"
+	// SelectorValue is the value of the selector for the KnativeServing resources.
 	SelectorValue = "knative-serving"
-	Selector      = SelectorKey + "=" + SelectorValue
+	// Selector is the selector for the KnativeServing resources.
+	Selector = SelectorKey + "=" + SelectorValue
 )
 
 // NewExtendedController returns a controller extended to a specific platform

test/e2e/knativeeventingdeployment_test.go

@@ -53,6 +53,7 @@ func TestKnativeEventingDeployment(t *testing.T) {
 	t.Run("restore", func(t *testing.T) {
 		resources.AssertKEOperatorCRReadyStatus(t, clients, names)
 		resources.DeleteAndVerifyEventingDeployments(t, clients, names)
+		resources.DeleteAndVerifyEventingConfigMaps(t, clients, names)
 	})
 
 	// Delete the KnativeEventing to see if all resources will be removed

test/e2e/knativeservingdeployment_test.go

@@ -58,6 +58,7 @@ func TestKnativeServingDeployment(t *testing.T) {
 	t.Run("restore", func(t *testing.T) {
 		resources.AssertKSOperatorCRReadyStatus(t, clients, names)
 		resources.DeleteAndVerifyDeployments(t, clients, names)
+		resources.DeleteAndVerifyConfigMaps(t, clients, names)
 	})
 
 	// Delete the KnativeServing to see if all resources will be removed

test/resources/verify.go

@@ -211,6 +211,47 @@ func DeleteAndVerifyDeployments(t *testing.T, clients *test.Clients, names test.
 	t.Logf("The deployment %s/%s reached the desired state.", deployment.Namespace, deployment.Name)
 }
 
+// DeleteAndVerifyConfigMaps verify whether all the ConfigMaps for knative serving are able to recreate, when they are deleted.
+func DeleteAndVerifyConfigMaps(t *testing.T, clients *test.Clients, names test.ResourceNames) {
+	cmList, err := clients.KubeClient.CoreV1().ConfigMaps(names.Namespace).List(context.TODO(), metav1.ListOptions{})
+	if err != nil {
+		t.Fatalf("Failed to get any ConfigMap under the namespace %q: %v",
+			test.ServingOperatorNamespace, err)
+	}
+	if len(cmList.Items) == 0 {
+		t.Fatalf("No ConfigMap under the namespace %q was found",
+			test.ServingOperatorNamespace)
+	}
+	// Delete the first ConfigMap and verify the operator recreates it
+	configMap := cmList.Items[0]
+	if err := clients.KubeClient.CoreV1().ConfigMaps(configMap.Namespace).Delete(context.TODO(), configMap.Name, metav1.DeleteOptions{}); err != nil {
+		t.Fatalf("Failed to delete ConfigMap %s/%s: %v", configMap.Namespace, configMap.Name, err)
+	}
+
+	waitErr := wait.PollUntilContextTimeout(context.TODO(), Interval, Timeout, true, func(context.Context) (bool, error) {
+		_, err := clients.KubeClient.CoreV1().ConfigMaps(configMap.Namespace).Get(context.TODO(), configMap.Name, metav1.GetOptions{})
+		if err != nil {
+			// If the ConfigMap is not found, we continue to wait for the availability.
+			if apierrs.IsNotFound(err) {
+				return false, nil
+			}
+			return false, err
+		}
+		// For ConfigMaps, we consider it recreated as soon as it reappears.
+		return true, nil
+	})
+
+	if waitErr != nil {
+		t.Fatalf("The ConfigMap %s/%s failed to be recreated: %v", configMap.Namespace, configMap.Name, err)
+	}
+
+	if _, err := WaitForKnativeServingState(clients.KnativeServing(), test.OperatorName,
+		IsKnativeServingReady); err != nil {
+		t.Fatalf("KnativeService %q failed to reach the desired state: %v", test.OperatorName, err)
+	}
+	t.Logf("The ConfigMap %s/%s was successfully recreated.", configMap.Namespace, configMap.Name)
+}
+
 // KSOperatorCRDelete deletes tha KnativeServing to see if all resources will be deleted
 func KSOperatorCRDelete(t *testing.T, clients *test.Clients, names test.ResourceNames) {
 	if err := clients.KnativeServing().Delete(context.TODO(), names.KnativeServing, metav1.DeleteOptions{}); err != nil {
@@ -399,6 +440,46 @@ func DeleteAndVerifyEventingDeployments(t *testing.T, clients *test.Clients, nam
 	t.Logf("The deployment %s/%s reached the desired state.", deployment.Namespace, deployment.Name)
 }
 
+// DeleteAndVerifyEventingConfigMaps verify whether all the ConfigMaps for knative eventing are able to recreate, when they are deleted.
+func DeleteAndVerifyEventingConfigMaps(t *testing.T, clients *test.Clients, names test.ResourceNames) {
+	cmList, err := clients.KubeClient.CoreV1().ConfigMaps(names.Namespace).List(context.TODO(), metav1.ListOptions{})
+	if err != nil {
+		t.Fatalf("Failed to get any ConfigMap under the namespace %q: %v",
+			test.EventingOperatorNamespace, err)
+	}
+	if len(cmList.Items) == 0 {
+		t.Fatalf("No ConfigMap under the namespace %q was found",
+			test.EventingOperatorNamespace)
+	}
+	// Delete the first ConfigMap and verify the operator recreates it
+	configMap := cmList.Items[0]
+	if err := clients.KubeClient.CoreV1().ConfigMaps(configMap.Namespace).Delete(context.TODO(), configMap.Name, metav1.DeleteOptions{}); err != nil {
+		t.Fatalf("Failed to delete ConfigMap %s/%s: %v", configMap.Namespace, configMap.Name, err)
+	}
+
+	waitErr := wait.PollUntilContextTimeout(context.TODO(), Interval, Timeout, true, func(context.Context) (bool, error) {
+		_, err := clients.KubeClient.CoreV1().ConfigMaps(configMap.Namespace).Get(context.TODO(), configMap.Name, metav1.GetOptions{})
+		if err != nil {
+			// If the ConfigMap is not found, we continue to wait for the availability.
+			if apierrs.IsNotFound(err) {
+				return false, nil
+			}
+			return false, err
+		}
+		return true, nil
+	})
+
+	if waitErr != nil {
+		t.Fatalf("The ConfigMap %s/%s failed to reach the desired state: %v", configMap.Namespace, configMap.Name, err)
+	}
+
+	if _, err := WaitForKnativeEventingState(clients.KnativeEventing(), test.OperatorName,
+		IsKnativeEventingReady); err != nil {
+		t.Fatalf("KnativeService %q failed to reach the desired state: %v", test.OperatorName, err)
+	}
+	t.Logf("The ConfigMap %s/%s reached the desired state.", configMap.Namespace, configMap.Name)
+}
+
 // KEOperatorCRDelete deletes tha KnativeEventing to see if all resources will be deleted
 func KEOperatorCRDelete(t *testing.T, clients *test.Clients, names test.ResourceNames) {
 	if err := clients.KnativeEventing().Delete(context.TODO(), names.KnativeEventing, metav1.DeleteOptions{}); err != nil {