Fix the build for android gradle plugin 9.0.1 (#181)

* Bump com.android.tools.build:gradle from 8.13.2 to 9.0.1

Bumps com.android.tools.build:gradle from 8.13.2 to 9.0.1.

---
updated-dependencies:
- dependency-name: com.android.tools.build:gradle
  dependency-version: 9.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* temporary fix for building with AGP 9.0.1

* fix PdTest progard build error with AGP 9.0.1

* fix CI on gradle update

* bump version 1.4.2-SNAPSHOT

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: Ant1r

.github/workflows/android.yml

@@ -25,7 +25,6 @@ jobs:
     - run: |
         git submodule sync --recursive
         git submodule update --init --recursive
-    - run: ./gradlew androidDependencies
     - run: ./gradlew clean
     - run: ./gradlew PdCore:pd-core:build
       env:

PdCore/build.gradle

@@ -4,7 +4,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:8.13.2'
+        classpath 'com.android.tools.build:gradle:9.0.1'
     }
 }
 
@@ -23,7 +23,7 @@ allprojects {
 // These are specific to PdCore, but nexusPublishing needs them here:
 // https://github.com/gradle-nexus/publish-plugin/issues/84
 group = 'io.github.libpd.android'
-version = '1.4.1-SNAPSHOT'
+version = '1.4.2-SNAPSHOT'
 
 // Create a Sonatype user token for these environment variables:
 // export ORG_GRADLE_PROJECT_sonatypeUsername="<tokenUsername>"

PdCore/gradle.properties

@@ -1 +1,14 @@
-android.useAndroidX=true
+android.useAndroidX=true
+
+# Bumping android gradle plugin from 8.13.2 to 9.0.1 breaks pd-core/build.gradle at 2 places:
+#
+# - android.libraryVariants cannot be resolved (used to rename the output aar).
+# It should be replaced with androidComponents{onVariants} but I couldn't get it to work...
+#
+# - android.compileSdk cannot be resolved either (needed to locate the android.jar for building javadoc)
+# I couldn't find a replacement.
+#
+# Using 'android.newDsl=false' is a temporary fix, until a solution is found for these 2 problems:
+
+android.newDsl=false
+

PdTest/build.gradle

@@ -31,7 +31,7 @@ android {
     buildTypes {
         release {
             minifyEnabled true
-            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
+            proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
         }
     }
 

README.md

@@ -45,7 +45,7 @@ allprojects {
 
 ```gradle
 dependencies {
-    implementation 'io.github.libpd.android:pd-core:1.4.1-SNAPSHOT'
+    implementation 'io.github.libpd.android:pd-core:1.4.2-SNAPSHOT'
 }
 ```
 

build.gradle

@@ -4,7 +4,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:8.13.2'
+        classpath 'com.android.tools.build:gradle:9.0.1'
     }
 }
 
@@ -20,5 +20,5 @@ ext {
     compileSdk = 34
     androidxLegacySupportVersion = '1.0.0'
     ndkVersion = libs.versions.ndk.get()
-    pdCoreVersion = '1.4.1-SNAPSHOT' // Must match version in PdCore/build.gradle
+    pdCoreVersion = '1.4.2-SNAPSHOT' // Must match version in PdCore/build.gradle
 }