Add affects availability check #5127
lint.yml
on: push
Lint Code Base
1m 6s
PHP Static Analysis
1m 8s
Rector (dry-run)
2m 17s
Annotations
11 errors and 2 warnings
|
PHP Static Analysis:
app/Http/Controllers/Device/EditPollingController.php#L156
Access to an undefined property Illuminate\Database\Eloquent\Model::$secret_id.
|
|
PHP Static Analysis:
app/Http/Controllers/Device/EditPollingController.php#L153
Parameter #2 $row of method App\Http\Controllers\Device\EditPollingController::updateSecret() expects App\Models\DevicePollingMethod, Illuminate\Database\Eloquent\Model given.
|
|
PHP Static Analysis:
app/Http/Controllers/Device/EditPollingController.php#L153
Access to an undefined property Illuminate\Database\Eloquent\Model::$secret_id.
|
|
PHP Static Analysis:
app/Http/Controllers/Device/EditPollingController.php#L142
Access to an undefined property Illuminate\Database\Eloquent\Model::$settings.
|
|
PHP Static Analysis:
app/Http/Controllers/Device/EditPollingController.php#L141
Access to an undefined property Illuminate\Database\Eloquent\Model::$affects_availability.
|
|
PHP Static Analysis:
app/Http/Controllers/Device/EditPollingController.php#L140
Access to an undefined property Illuminate\Database\Eloquent\Model::$enabled.
|
|
PHP Static Analysis:
app/Data/Polling/Methods/UnixAgent.php#L36
Method App\Data\Polling\Methods\UnixAgent::getSettingsSchema() should return array<string, array{type: string, options?: array<string, string>, visible_if: array}> but returns array{port: array{type: 'number', default: 6556, min: 1, max: 65535}}.
|
|
PHP Static Analysis:
app/Data/Polling/Methods/Snmp.php#L44
Method App\Data\Polling\Methods\Snmp::getSettingsSchema() should return array<string, array{type: string, options?: array<string, string>, visible_if: array}> but returns array{transport: array{type: 'select', options: array{udp: 'UDP', tcp: 'TCP', udp6: 'UDP6', tcp6: 'TCP6'}}, port: array{type: 'number'}, timeout: array{type: 'number'}, retries: array{type: 'number'}, max_repeaters: array{type: 'number'}, max_oid: array{type: 'number'}}.
|
|
PHP Static Analysis:
app/Data/Polling/Methods/Ipmi.php#L19
Method App\Data\Polling\Methods\Ipmi::getSettingsSchema() should return array<string, array{type: string, options?: array<string, string>, visible_if: array}> but returns array{hostname: array{type: 'text'}, port: array{type: 'number'}, ciphersuite: array{type: 'text'}, timeout: array{type: 'number'}}.
|
|
PHP Static Analysis:
LibreNMS/Data/Source/NetSnmpQuery.php#L342
Method LibreNMS\Data\Source\NetSnmpQuery::buildAuth() is unused.
|
|
Rector (dry-run)
Process completed with exit code 2.
|
|
PHP Static Analysis
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Rector (dry-run)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|