node def entity clone: make feature experimental (#4215)

Author: SteRiccio

webapp/components/survey/SurveyForm/nodeDefs/components/nodeDefEditButtonsMenu.js

@@ -12,6 +12,7 @@ import { Button, ButtonDelete, ButtonMenu } from '@webapp/components'
 
 import { NodeDefEntitySelectorDialog } from './nodeDefEntitySelectorDialog'
 import { NodeDefConversionDialog } from './nodeDefConversionDialog'
+import { useSystemConfigExperimentalFeatures } from '@webapp/store/system'
 
 const actionsWithEntitySelection = { clone: 'clone', move: 'move' }
 
@@ -39,7 +40,8 @@ const isEntitySelectableByAction = {
 }
 
 const availabilityByAction = {
-  [actionsWithEntitySelection.clone]: () => true,
+  [actionsWithEntitySelection.clone]: ({ nodeDef, experimentalFeatures }) =>
+    experimentalFeatures || NodeDef.isAttribute(nodeDef),
   [actionsWithEntitySelection.move]: ({ survey, cycle, nodeDef }) => {
     // published node defs cannot be moved
     if (NodeDef.isPublished(nodeDef)) return false
@@ -71,6 +73,7 @@ export const NodeDefEditButtonsMenu = (props) => {
   const dispatch = useDispatch()
   const navigate = useNavigate()
 
+  const experimentalFeatures = useSystemConfigExperimentalFeatures()
   const survey = useSurvey()
   const cycle = useSurveyCycleKey()
   const lang = useSurveyPreferredLang()
@@ -129,7 +132,7 @@ export const NodeDefEditButtonsMenu = (props) => {
     const _menuItems = []
     // items with entity selection (clone or move actions)
     const availableActions = Object.keys(actionsWithEntitySelection).filter((action) =>
-      availabilityByAction[action]({ survey, cycle, nodeDef })
+      availabilityByAction[action]({ survey, cycle, nodeDef, experimentalFeatures })
     )
     _menuItems.push(
       ...availableActions.map((action) => ({
@@ -180,7 +183,16 @@ export const NodeDefEditButtonsMenu = (props) => {
       })
     }
     return _menuItems
-  }, [cycle, dispatch, nodeDef, nodeDefLabel, openConvertIntoDialog, openEntitySelectDialog, survey])
+  }, [
+    cycle,
+    dispatch,
+    experimentalFeatures,
+    nodeDef,
+    nodeDefLabel,
+    openConvertIntoDialog,
+    openEntitySelectDialog,
+    survey,
+  ])
 
   if (menuItems.length === 0) return null
 

webapp/store/system/info/hooks.js

@@ -0,0 +1,10 @@
+import { useSelector } from 'react-redux'
+
+import * as SystemInfoState from './state'
+
+export const useSystemAppInfo = () => useSelector(SystemInfoState.getAppInfo)
+export const useSystemConfig = () => useSelector(SystemInfoState.getConfig)
+export const useSystemConfigExperimentalFeatures = (): boolean =>
+  useSelector(SystemInfoState.getConfigExperimentalFeatures)
+export const useSystemConfigFileUploadLimit = (): number => useSelector(SystemInfoState.getConfigFileUploadLimit)
+export const useSystemConfigFileUploadLimitMB = (): number => useSelector(SystemInfoState.getConfigFileUploadLimitMB)