implement the suggestions

Author: Omswastik-11

openml/_api/resources/flow.py

@@ -1,12 +1,12 @@
 from __future__ import annotations
 
-from collections.abc import Mapping
 from typing import Any
+from urllib.parse import quote
 
 import pandas as pd
 import xmltodict
 
-from openml.exceptions import OpenMLServerError, OpenMLServerException
+from openml.exceptions import OpenMLServerException, OpenMLServerNoResult
 from openml.flows.flow import OpenMLFlow
 
 from .base import FlowAPI, ResourceV1API, ResourceV2API
@@ -61,8 +61,11 @@ def exists(self, name: str, external_version: str) -> int | bool:
         if not (isinstance(external_version, str) and len(external_version) > 0):
             raise ValueError("Argument 'version' should be a non-empty string")
 
-        data = {"name": name, "external_version": external_version, "api_key": self._http.api_key}
-        xml_response = self._http.post("flow/exists", data=data).text
+        data: dict[str, str] = {"name": name, "external_version": external_version}
+        if self._http.api_key:
+            data["api_key"] = self._http.api_key
+
+        xml_response = self._http.post("flow/exists", data=data, use_api_key=False).text
         result_dict = xmltodict.parse(xml_response)
         # Detect error payloads and raise
         if "oml:error" in result_dict:
@@ -196,14 +199,20 @@ def exists(self, name: str, external_version: str) -> int | bool:
         if not (isinstance(external_version, str) and len(external_version) > 0):
             raise ValueError("Argument 'version' should be a non-empty string")
 
+        name_path = quote(name, safe="")
+        version_path = quote(external_version, safe="")
+
         try:
-            response = self._http.get(f"flows/exists/{name}/{external_version}/")
+            response = self._http.get(f"flows/exists/{name_path}/{version_path}/")
             result = response.json()
             flow_id: int | bool = result.get("flow_id", False)
             return flow_id
-        except (OpenMLServerError, KeyError):
-            # v2 returns 404 when flow doesn't exist, which raises OpenMLServerError
+        except OpenMLServerNoResult:
             return False
+        except OpenMLServerException as err:
+            if err.code == 404:
+                return False
+            raise
 
     def list(
         self,
@@ -214,9 +223,6 @@ def list(
     ) -> pd.DataFrame:
         self._not_supported(method="list")
 
-    def publish(self, path: str | None = None, files: Mapping[str, Any] | None = None) -> int:  # type: ignore[override]  # noqa: ARG002
-        self._not_supported(method="publish")
-
     @staticmethod
     def _convert_v2_to_v1_format(v2_json: dict[str, Any]) -> dict[str, dict]:
         """Convert v2 JSON response to v1 XML-dict format for OpenMLFlow._from_dict().

openml/flows/functions.py

@@ -2,20 +2,17 @@
 from __future__ import annotations
 
 from functools import partial
-from typing import Any, cast
+from typing import Any
 
 import dateutil.parser
 import pandas as pd
 import xmltodict
 
 import openml
-import openml._api_calls
 import openml.utils
 
 from . import OpenMLFlow
 
-FLOWS_CACHE_DIR_NAME = "flows"
-
 
 @openml.utils.thread_safe_if_oslo_installed
 def get_flow(
@@ -182,9 +179,7 @@ def flow_exists(name: str, external_version: str) -> int | bool:
     if not (isinstance(external_version, str) and len(external_version) > 0):
         raise ValueError("Argument 'version' should be a non-empty string")
 
-    return cast(
-        "int | bool", openml._backend.flow.exists(name=name, external_version=external_version)
-    )
+    return openml._backend.flow.exists(name=name, external_version=external_version)
 
 
 def get_flow_id(
@@ -511,4 +506,4 @@ def delete_flow(flow_id: int) -> bool:
     >>> # Deletes flow 23 if you are the uploader and it's not linked to runs
     >>> openml.flows.delete_flow(23)  # doctest: +SKIP
     """
-    return openml._backend.flow.delete(flow_id)  # type: ignore
+    return openml._backend.flow.delete(flow_id)

tests/test_api/test_flow.py

@@ -74,7 +74,7 @@ def test_flow_v1_exists_input_validation(flow_v1):
         flow_v1.exists(name="sklearn.tree.DecisionTreeClassifier", external_version="")
 
 
-def test_flow_v1_exists_mocked_success(flow_v1, test_apikey_v1):
+def test_flow_v1_exists_mocked_success(flow_v1):
     flow_name = "sklearn.tree.DecisionTreeClassifier"
     external_version = "1"
 
@@ -90,18 +90,15 @@ def test_flow_v1_exists_mocked_success(flow_v1, test_apikey_v1):
         result = flow_v1.exists(name=flow_name, external_version=external_version)
 
         assert result == 123
-        mock_request.assert_called_once_with(
-            method="POST",
-            url=openml.config.server + "flow/exists",
-            params={},
-            data={
-                "name": flow_name,
-                "external_version": external_version,
-                "api_key": test_apikey_v1,
-            },
-            headers=openml.config._HEADERS,
-            files=None,
-        )
+        mock_request.assert_called_once()
+        _, kwargs = mock_request.call_args
+        assert kwargs["method"] == "POST"
+        assert kwargs["url"] == openml.config.server + "flow/exists"
+        assert kwargs["params"] == {}
+        assert kwargs["headers"] == openml.config._HEADERS
+        assert kwargs["files"] is None
+        assert kwargs["data"]["name"] == flow_name
+        assert kwargs["data"]["external_version"] == external_version
 
 
 def test_flow_v1_exists_mocked_server_error(flow_v1):

tests/test_flows/test_flow.py

@@ -329,7 +329,7 @@ def test_publish_error(self, mock_request, flow_exists_mock, get_flow_mock):
             "<oml:upload_flow>\n" "    <oml:id>1</oml:id>\n" "</oml:upload_flow>"
         ).encode()
         mock_request.return_value = response
-        flow_exists_mock.return_value = None  # Flow doesn't exist yet, so try to publish
+        flow_exists_mock.return_value = False  # Flow doesn't exist yet, so try to publish
         get_flow_mock.return_value = flow
 
         flow.publish()