Skip to content

Commit 32b15b0

Browse files
authored
Merge pull request #3743 from plotly/migrate-gha
Migrate circle gha (config)
2 parents 029fb8f + 97f15a9 commit 32b15b0

24 files changed

Lines changed: 3689 additions & 1136 deletions

File tree

.circleci/config.yml

Lines changed: 0 additions & 507 deletions
This file was deleted.

.github/workflows/testing.yml

Lines changed: 659 additions & 112 deletions
Large diffs are not rendered by default.

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
lts/iron
1+
24

.test_durations

Lines changed: 333 additions & 0 deletions
Large diffs are not rendered by default.

components/dash-core-components/.test_durations

Lines changed: 428 additions & 0 deletions
Large diffs are not rendered by default.

components/dash-core-components/tests/integration/graph/test_graph_responsive.py

Lines changed: 24 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,18 +4,35 @@
44
import flaky
55

66
from dash import Dash, Input, Output, State, dcc, html
7-
import plotly.graph_objects as go
87

98
from dash.exceptions import PreventUpdate
109
from dash.testing import wait
1110

1211

13-
@pytest.mark.parametrize("responsive", [True, False, None])
14-
@pytest.mark.parametrize("autosize", [True, False, None])
15-
@pytest.mark.parametrize("height", [600, None])
16-
@pytest.mark.parametrize("width", [600, None])
17-
@pytest.mark.parametrize("is_responsive", [True, False, "auto"])
18-
def test_grrs001_graph(dash_dcc, responsive, autosize, height, width, is_responsive):
12+
@pytest.mark.parametrize(
13+
"is_responsive,responsive,autosize,height,width",
14+
[
15+
# is_responsive=True: always responsive regardless of other params
16+
(True, None, None, None, None),
17+
(True, False, False, 600, 600), # still responsive even with fixed dims
18+
# is_responsive=False: never responsive regardless of other params
19+
(False, True, True, None, None), # not responsive even with autosize
20+
(False, None, None, 600, 600),
21+
# is_responsive="auto": behavior depends on other params
22+
("auto", True, True, None, None), # responsive: all conditions met
23+
("auto", True, True, 600, None), # responsive: one dim fixed is ok
24+
("auto", True, False, None, None), # NOT responsive: autosize=False
25+
(
26+
"auto",
27+
False,
28+
True,
29+
None,
30+
None,
31+
), # NOT responsive on resize: config.responsive=False
32+
("auto", None, None, 600, 600), # NOT responsive: both dims fixed
33+
],
34+
)
35+
def test_grrs001_graph(dash_dcc, is_responsive, responsive, autosize, height, width):
1936
app = Dash(__name__, eager_loading=True)
2037

2138
header_style = dict(padding="10px", backgroundColor="yellow", flex="0 0 100px")

components/dash-html-components/scripts/generate-components.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -355,6 +355,7 @@ if (!listPath) {
355355
const list = fs
356356
.readFileSync(listPath, 'utf8')
357357
.split('\n')
358+
.map(item => item.trim())
358359
.filter(item => Boolean(item));
359360

360361
// Get the mapping of attributes to elements

components/dash-table/.test_durations

Lines changed: 459 additions & 389 deletions
Large diffs are not rendered by default.

components/dash-table/package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

components/dash-table/tests/selenium/conftest.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import platform
2+
import time
23
import pytest
34
from functools import wraps
45
import inspect
@@ -617,6 +618,9 @@ def copy(self):
617618
with self.hold(CMD):
618619
self.send_keys("c")
619620

621+
# Small wait to let Chrome stabilize focus after clipboard operation
622+
time.sleep(0.1)
623+
620624
def paste(self):
621625
with self.hold(CMD):
622626
self.send_keys("v")

0 commit comments

Comments
 (0)