Skip to content

Monorepos and README detection #2389

@KiwiKilian

Description

@KiwiKilian

See discussions in #2385.

Monorepo setup

Our project @maplibre/maplibre-react-native is a monorepo, the README.md is handle like this:

  • Placed in the GitHub repository root /
  • Copied during prepack into the /package directory, removed on postpack
  • Is in the /.gitignore for the /package/README.md path

Why are we doing this?

  • Keeps the README.md visible when someone opens the repository on GitHub
  • Properly publishes the README.md in the tarball
  • README.md is properly displayed/rendered on npmjs.com and RN Directory

Issue

The RN Directory scoring logic states the package has no README.md while rendering it next to it.

Image

Analysis by @Simek: The scoring logic checks whether a package has a README.md by querying the npm registry API (https://registry.npmjs.org/@maplibre/maplibre-react-native). Which in this case returns "No README data found".

Proposed solution

Use the same endpoints as for rendering the README.md on the client to check, if one is present for the scoring.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions