Sight Hide not working right - Turns off all sights now. (Later)

[rgleason]

I think sight > HIDE is intended to not show any sights that are hidden.
Right now it is just turning off all sites.

I believe the intention is to only show "Unhidden eyball ON" sights.
It is not working this way.

For some reason the ON eyeballs are not being written

[rbossert149419]

On my imac and windows 10, HIDE button only "hides" the Celestial Navigation Sights and Menu. It does not hide the COP/LOP. It has always worked that way (my mac book pro laptop is still at production version).

Although documentation is sparse and I can't absolutely prove it, I always thought it was intended to work as a similar manner as hide and show hides and shows the Open CPN toolbar. The purpose being to get the Sights menu out of the way so that the user can do some navigation work without the Sights menu getting in the way. Without Show and Hide, I'd have to move the Sights Menu to the corner of my display.

I've used Cel Nav for a few years, and it never turned on or off the COP or LOP. That's done by clicking on the Eyeball for each sight.

In my opinion the navigation user will turn-on the COP/LOP for a limited number of bodies at a time to determine a fix. The goal is to make a 3 body fix. Selecting one sight out of a line of sights for each of the 3 bodies). The navigator will click on and off the eyeball for a limited number of sights made in a short period of time (say made within 20 minutes or so) and then choose the best of the 3 body fixes to form the LOP/COP. The navigator will rarely turn on every sight's COP/LOP taken at different dates and then need to turn off those sights.

But the Hide/Show should be improved so that it works similarly as the Hide/Show does for hiding and showing the OpenCPN Toolbar. And maybe the Hide/show button should look like the other OpenCPN hide/show buttons. Anyway, that's my two cents.

[rgleason]

Ok Bob has a point.

The Hide button closes and fully opens the Sight list or logs.

Then there should be a master button show all/hide no-show sights but
just above the eye field in typical opencpn form.

Also sorting of fields might be considered?

[rbossert149419]

If the Celestial Sights form is to be prioritized for enhancement, you might want to consider moving the Hide and Show Button to where the NEW button currently is. And moving New button down along with the rest of the left side buttons, downward. By doing that, you can make the Celestial Sights form smaller width (just to show the Show Button) and smaller height (just to show the Show Button).

It would be nice to be able to sort on the fields such as Dates/Time (Ascending or Descending). It seems to be sorting (ascending) on the system date the sight was saved.

And add the DR Position (lat and long) with the sight.

May I suggest.....I recommend the above for a future release. I'd prefer to implement what we've done and then follow up with another release later. And before we implement this release, I suggest that we work on bugs that are issues that were created by this release. And be cautious to prioritize long outstanding bugs that we haven't yet fixed. I suspect those long outstanding bugs have an acceptable workaround. And we can fix the long outstanding bugs in the next release. Anyway, that's my suggestion. It is getting close to boating season.

[rbossert149419]

I have no issue with what Rick recommends for showing or hiding COP/LOP on the top line of the form like Routes and waypoints are shown or hidden. It makes Cel Nav consistent with OpenCPN core.

[rgleason]

Bob this all makes sense. Agreed, get the plugin out. Then fix it

[stelian42]

I agree the hide/show feature is broken. Need to be fixed, later.

Turn this into a RFE, and maybe make it a "Main dialog" RFE with the other suggestions about sortable columns etc

[rbossert149419]

This can be done at the same time we do other improvements to the Celestial Sights folder.

[rgleason]

See Discussion #155

[rgleason]

Fixed