Skip to content

Commit eb34ce8

Browse files
Merge pull request #82 from jan--f/note-naming-convention
Add a note about following naming conventions in OCP
2 parents e6bc65a + fac75e1 commit eb34ce8

2 files changed

Lines changed: 3 additions & 1 deletion

File tree

content/Products/OpenshiftMonitoring/instrumentation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Prometheus supports 4 [metric types](https://prometheus.io/docs/concepts/metric_
2727

2828
Adding metrics for any operation should be part of the code review process like any other factor that is kept in mind for production ready code.
2929

30-
To learn more about when to use which metric type, how to name metrics and how to choose labels, read the following documentation:
30+
To learn more about when to use which metric type, how to name metrics and how to choose labels, read the following documentation. {{% alert color="info" %}}OpenShift follows the outlined conventions whenever possible. Any exceptions should be reviewed and properly motivated.{{% /alert %}}
3131
* [Prometheus naming recommendations](https://prometheus.io/docs/practices/naming/)
3232
* [Prometheus instrumentation](https://prometheus.io/docs/practices/instrumentation/)
3333
* [Kubernetes metric instrumentation guide](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/metric-instrumentation.md)

content/Products/OpenshiftMonitoring/telemetry.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ spec:
110110

111111
Your `PrometheusRule` object(s) should be created by your operator with your `ServiceMonitor` and/or `PodMonitor` objects.
112112

113+
Recording rule names should follow the [`level:metric:operations` pattern](https://prometheus.io/docs/practices/rules/).
114+
113115
### Modify the Telemeter client's configuration
114116

115117
1. Clone the [cluster-monitoring-operator](https://github.com/openshift/cluster-monitoring-operator) repository locally.

0 commit comments

Comments
 (0)