fix(tracking): improve ByteTrackFactory with try-except approach and logging

Author: rogermt

plugins/forgesyte-yolo-tracker/src/forgesyte_yolo_tracker/tracking.py

@@ -6,9 +6,12 @@
 """
 
 import inspect
+import logging
 
 import supervision as sv
 
+logger = logging.getLogger(__name__)
+
 
 class ByteTrackFactory:
     """Lazy, class-based singleton for API-adaptive ByteTrack construction.
@@ -31,36 +34,69 @@ class ByteTrackFactory:
     def _build(cls) -> sv.ByteTrack:
         """Build ByteTrack with correct parameters for installed supervision version.
 
+        Uses a defensive try-except approach: attempts both API signatures
+        and uses whichever one succeeds.
+
         Returns:
             sv.ByteTrack: Configured tracker instance
 
         Raises:
-            RuntimeError: If neither old nor new API signatures are recognized
+            RuntimeError: If both API signatures fail
         """
-        sig = inspect.signature(sv.ByteTrack)
-
-        if "track_thresh" in sig.parameters:
-            # Older supervision API (< 0.23)
-            return sv.ByteTrack(
-                track_thresh=0.25,
-                track_buffer=30,
-                match_thresh=0.8,
-                frame_rate=30,
-            )
-
-        if "track_activation_threshold" in sig.parameters:
-            # Newer supervision API (>= 0.23)
-            return sv.ByteTrack(
+        sv_version = getattr(sv, "__version__", "unknown")
+        logger.info("ByteTrackFactory._build() called")
+        logger.info(f"supervision version: {sv_version}")
+
+        # Inspect signature for logging
+        try:
+            sig = inspect.signature(sv.ByteTrack)
+            params = list(sig.parameters.keys())
+            logger.info(f"sv.ByteTrack signature params: {params}")
+        except Exception as e:
+            logger.warning(f"Could not inspect ByteTrack signature: {e}")
+            params = []
+
+        # STRATEGY: Try both APIs in order, use whichever works
+        # This is more reliable than signature inspection which can be fooled
+        # by decorators, wrappers, or __init__ overrides
+
+        # Try NEW API first (more recent supervision versions)
+        logger.info("Attempting NEW API (track_activation_threshold)...")
+        try:
+            tracker = sv.ByteTrack(
                 track_activation_threshold=0.25,
                 lost_track_buffer=30,
                 minimum_matching_threshold=0.8,
                 frame_rate=30,
             )
-
-        raise RuntimeError(
-            f"Unsupported ByteTrack constructor signature. "
-            f"Available params: {list(sig.parameters.keys())}"
+            logger.info("SUCCESS: ByteTrack created with NEW API")
+            return tracker
+        except TypeError as e:
+            logger.info(f"NEW API failed: {e}")
+
+        # Try OLD API (older supervision versions)
+        logger.info("Attempting OLD API (track_thresh)...")
+        try:
+            tracker = sv.ByteTrack(
+                track_thresh=0.25,
+                track_buffer=30,
+                match_thresh=0.8,
+                frame_rate=30,
+            )
+            logger.info("SUCCESS: ByteTrack created with OLD API")
+            return tracker
+        except TypeError as e:
+            logger.info(f"OLD API failed: {e}")
+
+        # Neither worked - raise comprehensive error
+        error_msg = (
+            f"ByteTrack construction failed with both API signatures. "
+            f"supervision version: {sv_version}, "
+            f"detected params: {params}. "
+            f"Please check supervision installation."
         )
+        logger.error(error_msg)
+        raise RuntimeError(error_msg)
 
     @classmethod
     def get(cls) -> sv.ByteTrack:
@@ -70,7 +106,10 @@ def get(cls) -> sv.ByteTrack:
             sv.ByteTrack: Singleton tracker instance
         """
         if cls._instance is None:
+            logger.debug("Creating new ByteTrack singleton instance")
             cls._instance = cls._build()
+        else:
+            logger.debug("Returning existing ByteTrack singleton instance")
         return cls._instance
 
     @classmethod
@@ -79,4 +118,5 @@ def reset(cls) -> None:
 
         Useful for testing or when tracker state needs to be cleared.
         """
+        logger.debug("Resetting ByteTrack singleton instance")
         cls._instance = None