Skip to content

Commit f7e6d21

Browse files
committed
refactor: cleanup
1 parent 3325c25 commit f7e6d21

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

.github/workflows/build.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
description: The ref of saucer to use
99
cmake:
1010
type: string
11+
# This default value shows off how to inline the desktop and loop module to produce a single shared library that contains all commonly required functionality
1112
default: -Dsaucer_bindings_static=ON -Dsaucer_bindings_modules="desktop;loop" -Dsaucer_bindings_inline_modules="desktop;loop"
1213
description: Additional CMake Arguments to pass
1314

@@ -26,25 +27,22 @@ jobs:
2627
- backend: WebView2
2728
platform: Windows
2829
os: windows-latest
29-
cmake-args: -Dglaze_DISABLE_SIMD_WHEN_SUPPORTED=ON
3030

3131
- backend: WebView2-Hack
3232
backend-override: WebView2
3333
platform: Windows
3434
os: windows-latest
35-
cmake-args: -Dsaucer_msvc_hack=ON -Dglaze_DISABLE_SIMD_WHEN_SUPPORTED=ON
35+
cmake-args: -Dsaucer_msvc_hack=ON
3636

3737
- backend: Qt
3838
platform: Linux
3939
os: ubuntu-latest
4040
container: archlinux:base-devel
41-
cmake-args: -Dglaze_DISABLE_SIMD_WHEN_SUPPORTED=ON
4241

4342
- backend: WebKitGtk
4443
platform: Linux
4544
os: ubuntu-latest
4645
container: archlinux:base-devel
47-
cmake-args: -Dglaze_DISABLE_SIMD_WHEN_SUPPORTED=ON
4846

4947
- backend: WebKit
5048
platform: MacOS
@@ -78,7 +76,12 @@ jobs:
7876
backend: ${{ matrix.backend-override || matrix.backend }}
7977
platform: ${{ matrix.platform }}
8078
build-type: ${{ matrix.config }}
81-
cmake-args: -DCMAKE_RUNTIME_OUTPUT_DIRECTORY="$(pwd)/bin" -DCMAKE_LIBRARY_OUTPUT_DIRECTORY="$(pwd)/bin" ${{ matrix.cmake-args }} ${{ github.event.inputs.cmake }}
79+
cmake-args: >
80+
-Dglaze_DISABLE_SIMD_WHEN_SUPPORTED=ON
81+
-DCMAKE_RUNTIME_OUTPUT_DIRECTORY="$(pwd)/bin"
82+
-DCMAKE_LIBRARY_OUTPUT_DIRECTORY="$(pwd)/bin"
83+
${{ matrix.cmake-args }}
84+
${{ github.event.inputs.cmake }}
8285
8386
- name: 📦 Upload Artifact
8487
uses: actions/upload-artifact@v4

README.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,10 @@ The workflows build in all configurations (Debug, MinSizeRel, RelWithDebInfo, Re
2626
- WebKitGtk
2727
- MacOS
2828
- WebKit
29+
- WebKit-Universal
2930
- Windows
3031
- WebView2
3132
- WebView2-Hack[^2]
32-
- WebView2-Rfl[^3]
33-
- WebView2-Hack-Rfl
3433

3534
## Building
3635

@@ -86,5 +85,3 @@ Also, beware that all bindings are community maintained and their conformance ma
8685
[^1]: For more information, checkout the official repository to see how the smartview is actually implemented under the hood.
8786

8887
[^2]: See the documentation: https://saucer.app/getting-started/cmake/#msvc-mutex
89-
90-
[^3]: Uses the reflect-cpp serializer instead of Glaze

0 commit comments

Comments
 (0)