Skip to content

Commit 541c1b5

Browse files
authored
fix(fork): scope task list invalidation to current workspace (#4350)
* fix(fork): scope task list invalidation to current workspace * fix(sidebar): remove mutation objects from useCallback deps Mutation objects are not referentially stable in TanStack Query v5 — only .mutate() and .mutateAsync() are stable. Removed deleteTaskMutation, deleteTasksMutation, markTaskReadMutation, and markTaskUnreadMutation from their respective useCallback dependency arrays to avoid unnecessary recreations on every mutation state update.
1 parent 0c69302 commit 541c1b5

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

apps/sim/app/workspace/[workspaceId]/components/message-actions/message-actions.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export const MessageActions = memo(function MessageActions({
7272
const resetTimeoutRef = useRef<number | null>(null)
7373
const requestIdTimeoutRef = useRef<number | null>(null)
7474
const submitFeedback = useSubmitCopilotFeedback()
75-
const forkTask = useForkTask()
75+
const forkTask = useForkTask(params.workspaceId)
7676

7777
useEffect(() => {
7878
return () => {

apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -896,7 +896,7 @@ export const Sidebar = memo(function Sidebar() {
896896
deleteTasksMutation.mutate(taskIdsToDelete, { onSuccess: onDeleteSuccess })
897897
}
898898
setIsTaskDeleteModalOpen(false)
899-
}, [pathname, workspaceId, deleteTaskMutation, deleteTasksMutation, navigateToPage])
899+
}, [pathname, workspaceId, navigateToPage])
900900

901901
const [visibleTaskCount, setVisibleTaskCount] = useState(5)
902902
const taskFlyoutRename = useFlyoutInlineRename({
@@ -935,13 +935,13 @@ export const Sidebar = memo(function Sidebar() {
935935
const { taskIds: ids } = contextMenuSelectionRef.current
936936
if (ids.length !== 1) return
937937
markTaskReadMutation.mutate(ids[0])
938-
}, [markTaskReadMutation])
938+
}, [])
939939

940940
const handleMarkTaskAsUnread = useCallback(() => {
941941
const { taskIds: ids } = contextMenuSelectionRef.current
942942
if (ids.length !== 1) return
943943
markTaskUnreadMutation.mutate(ids[0])
944-
}, [markTaskUnreadMutation])
944+
}, [])
945945

946946
const handleStartTaskRename = useCallback(() => {
947947
const { taskIds: ids } = contextMenuSelectionRef.current

apps/sim/hooks/queries/tasks.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -605,12 +605,12 @@ async function forkChat(params: {
605605
return { id: data.id }
606606
}
607607

608-
export function useForkTask() {
608+
export function useForkTask(workspaceId?: string) {
609609
const queryClient = useQueryClient()
610610
return useMutation({
611611
mutationFn: forkChat,
612612
onSettled: () => {
613-
queryClient.invalidateQueries({ queryKey: taskKeys.lists() })
613+
queryClient.invalidateQueries({ queryKey: taskKeys.list(workspaceId) })
614614
},
615615
})
616616
}

0 commit comments

Comments
 (0)