Embed import broken on 1.31.1

[firefart]

Version

1.31.1

What happened?

Install of 1.31.1 fails with

go: github.com/sqlc-dev/sqlc/cmd/sqlc imports
github.com/sqlc-dev/sqlc/internal/cmd imports
github.com/ncruces/go-sqlite3/embed: cannot find module providing package github.com/ncruces/go-sqlite3/embed

see here for details: ncruces/go-sqlite3#368 (comment)

According to the comment the references to _ "github.com/ncruces/go-sqlite3/embed" need to be removed

This package causes a lot of problems downstreams it seems ....

[firefart]

also here are the update instructions from the changelog https://github.com/ncruces/go-sqlite3/releases

[toofishes]

If you have a line like this in your go.mod:

github.com/ncruces/go-sqlite3 v0.33.3 // indirect

Modify it to the older version, run go mod tidy, and things started working for me again:

github.com/ncruces/go-sqlite3 v0.32.0 // indirect

[firefart]

@toofishes yes but every time you run go get -u or go get -u tool the dependency gets updated. I ended up adding a replace directive in my local go.mod's for now until this is ifxed

replace github.com/ncruces/go-sqlite3 => github.com/ncruces/go-sqlite3 v0.32.0

[kyleconroy]

We're stuck in a bit of a bind here. We can't upgrade to v0.33.3 because it depends on a version of a different library.

Our version is set to v0.32.0 and you'll need to keep it set to that version. They really should have upgraded to a v2 since the API changed.

[ptman]

@kyleconroy they should have, but semver 0. doesn't guarantee anything

[kyleconroy]

I've upgraded to 0.34 which should hopefully fix this. Let me know!

[firefart]

yes 0.34 fixes it, removed the replace directive and everything works as expected now.
PS: The deprecation notice is now printed on each sqlc run, so that might confuse some users until sqlc is upgraded to the latest go-sqlite3 version.
Thanks for looking into this!